Jv dependency injection solution #699
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Denis-Balako
suggested changes
Aug 4, 2023
| break; | ||
| } | ||
| } | ||
| System.out.println(clazzInterface + " " + interfaceImplementation); |
There was a problem hiding this comment.
used for quick check, forgot to delete)
Comment on lines
109
to
119
| public static List<Class<?>> findClassesByPackage(String packageName) { | ||
| String path = packageName.replace('.', '/'); | ||
| ClassLoader classLoader = Thread.currentThread().getContextClassLoader(); | ||
| File packageDirectory = new File(classLoader.getResource(path).getFile()); | ||
| File[] files = packageDirectory.listFiles(); | ||
| return Arrays.stream(files) | ||
| .filter(File::isFile) | ||
| .filter(file -> file.getName().endsWith(CLASS_INDICATOR)) | ||
| .map(file -> getClass(file.getName(), packageName)) | ||
| .collect(Collectors.toList()); | ||
| } |
There was a problem hiding this comment.
public methods should be before private
Comment on lines
66
to
77
| if (interfaceClazz.isInterface()) { | ||
| if (!interfacesImplementations.containsKey(interfaceClazz)) { | ||
| throw new RuntimeException("Can`t find interface " + interfaceClazz.getName()); | ||
| } | ||
| Class<?> implementation = interfacesImplementations.get(interfaceClazz); | ||
| if (implementation == null) { | ||
| throw new RuntimeException("Interface " + interfaceClazz.getName() | ||
| + " has no implementations or they doesn't annotated by @Component"); | ||
| } | ||
| return implementation; | ||
| } | ||
| componentCheck(interfaceClazz); |
There was a problem hiding this comment.
You should decide how to check exceptions: in separate methods or in this method.
| public class Injector { | ||
| private static final Injector injector = new Injector(); | ||
| private static final Map<Class<?>, Class<?>> interfacesImplementations; |
There was a problem hiding this comment.
From my point of view, we need to follow KISS principles and use just "Map.of(...)" for interface implementations.
Vasul-Pankiv
suggested changes
Aug 8, 2023
Comment on lines
71
to
77
| private static Map<Class<?>, Class<?>> interfacesImplementationsConfig() { | ||
| Map<Class<?>, Class<?>> map = new HashMap<>(); | ||
| map.put(FileReaderService.class, FileReaderServiceImpl.class); | ||
| map.put(ProductParser.class, ProductParserImpl.class); | ||
| map.put(ProductService.class, ProductServiceImpl.class); | ||
| return map; | ||
| } |
There was a problem hiding this comment.
Common mistakes: "Make Interface Implementations map a class field. You can fill it in using Map.of()"
andrii-hoienko
suggested changes
Aug 8, 2023
| } | ||
| } | ||
|
|
||
| private static Class<?> findImplementation(Class<?> interfaceClazz) { |
There was a problem hiding this comment.
Why all private methods is static?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.