Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done solution #714

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

done solution #714

wants to merge 3 commits into from

Conversation

DaniilNepelev
Copy link

No description provided.

Copy link

@ArtemReizer ArtemReizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution!

Copy link

@andrii-hoienko andrii-hoienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, minor fix and you are done

}

private Class<?> getComponentClass(Class<?> interfaceClazz) {
Class<?> componentClass = interfaceClazz.isInterface()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad variable name it is not componentClass at least you dont know about that on this moment

Copy link
Contributor

@nacenik nacenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants