add calc+test #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sofasmile
reviewed
Oct 15, 2019
|
|
||
| @Test(expected = IllegalArgumentException.class) | ||
| public void checkIllegalArg() { | ||
| double number1 = Math.random(); |
There was a problem hiding this comment.
can we use random values in tests?
| Assert.assertEquals(expected, actual, 0); | ||
| expected = number1 - number2; | ||
| actual = calculator.calculate(number1, number2, '3'); | ||
| Assert.assertEquals(expected, actual, 0); |
There was a problem hiding this comment.
чи потрібні нам наступні тестові дані, якщо перший уже викине помилку
|
|
||
| @Test | ||
| public void checkNotCorrectOperation() { | ||
| double number1 = Math.random(); |
There was a problem hiding this comment.
What is the purpose of this test?
There was a problem hiding this comment.
we do not need it, deleted done
| expected = Math.pow(number1, number2); | ||
| actual = calculator.calculate(number1, number2, '^'); | ||
| Assert.assertEquals(actual, expected, 0); | ||
| number1 = -Math.random(); |
There was a problem hiding this comment.
better divide this test into two separate with positive and negative numbers
| expected = number1 * number2; | ||
| actual = calculator.calculate(number1, number2, '*'); | ||
| Assert.assertEquals(actual, expected, 0); | ||
| expected = number1 / number2; |
There was a problem hiding this comment.
will we have excaption here?
There was a problem hiding this comment.
no, the result will be infinity
|
|
||
| @Test | ||
| public void CheckNullPointer() { | ||
| Double number1 = null; |
| Double number2 = null; | ||
|
|
||
| } | ||
| } |
Sofasmile
reviewed
Oct 15, 2019
| import org.junit.Test; | ||
|
|
||
| public class CalculatorTest { | ||
| private Calculator calculator = new Calculator(); |
|
|
||
| @Test | ||
| public void checkCorrectNegative() { | ||
| double number1 = -Math.random(); |
| @Test(expected = NullPointerException.class) | ||
| public void CheckNullPointer() { | ||
|
|
||
| Double number1 = 1.0/0; |
Sofasmile
reviewed
Oct 15, 2019
| import org.junit.Test; | ||
|
|
||
| public class CalculatorTest { | ||
| Calculator calculator = null; |
Sofasmile
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.