Completed task #14
Open
Completed task #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuzan
suggested changes
Aug 3, 2023
| throw new RuntimeException("Can't create connection to DB ", e); | ||
| } | ||
| } | ||
| } |
| } | ||
| return Optional.ofNullable(book); | ||
| } catch (SQLException e) { | ||
| throw new RuntimeException(e); |
|
|
||
| @Override | ||
| public Book update(Book book) { | ||
| String updateBookQuery = "UPDATE books SET title = ?, price = ?;"; |
| } | ||
| return book; | ||
| } catch (SQLException e) { | ||
| throw new RuntimeException(e); |
| connection.prepareStatement(deleteByIdQuery)) { | ||
| deleteByIdStatement.setLong(1, id); | ||
| int deletedRows = deleteByIdStatement.executeUpdate(); | ||
| return deletedRows != 0; |
There was a problem hiding this comment.
Suggested change
| return deletedRows != 0; | |
| return deletedRows > 0; |
Comment on lines
29
to
31
| if (insertedRows < 1) { | ||
| throw new RuntimeException("Expected to insert at least 1 row, but nothing was inserted"); | ||
| } |
|
|
||
| @Override | ||
| public boolean deleteById(Long id) { | ||
| String deleteByIdQuery = "UPDATE books SET is_deleted = true WHERE id = ?;"; |
There was a problem hiding this comment.
Suggested change
| String deleteByIdQuery = "UPDATE books SET is_deleted = true WHERE id = ?;"; | |
| String deleteByIdQuery = "UPDATE books SET is_deleted = TRUE WHERE id = ?;"; | |
kozhukhovsky
approved these changes
Aug 3, 2023
hronograf
approved these changes
Aug 4, 2023
sokimaaa
approved these changes
Aug 4, 2023
sokimaaa
approved these changes
Aug 4, 2023
sokimaaa
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.