JDBC Intro Solution #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozhukhovsky
suggested changes
Aug 6, 2023
Comment on lines
8
to
12
| Book create(Book book); | ||
| Optional<Book> findById(Long id); | ||
| List<Book> findAll(); | ||
| Book update(Book book); | ||
| boolean deleteById(Long id); |
There was a problem hiding this comment.
Suggested change
| Book create(Book book); | |
| Optional<Book> findById(Long id); | |
| List<Book> findAll(); | |
| Book update(Book book); | |
| boolean deleteById(Long id); | |
| Book create(Book book); | |
| Optional<Book> findById(Long id); | |
| List<Book> findAll(); | |
| Book update(Book book); | |
| boolean deleteById(Long id); |
|
|
||
| @Override | ||
| public Book create(Book book) { | ||
| if (book.getTitle() == null || book.getPrice() == null) { |
There was a problem hiding this comment.
optional validation in this case
and as a rule, validation is not done at the dao level
Comment on lines
46
to
48
| if (affectedRows < LESS_THAN_ONE) { | ||
| throw new RuntimeException(AT_LEAST_ONE_ROW_EXCEPTION); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (affectedRows < LESS_THAN_ONE) { | |
| throw new RuntimeException(AT_LEAST_ONE_ROW_EXCEPTION); | |
| } |
| public class BookDaoImpl implements BookDao { | ||
| private static final String AT_LEAST_ONE_ROW_EXCEPTION | ||
| = "Expected to insert at least one row, but inserted 0 rows"; | ||
| private static final String ADD_BOOK_EXCEPTION = "Cannot add new book: "; |
There was a problem hiding this comment.
If the text for each error is different, I would not take it out as constants.
Comment on lines
62
to
64
| if (id < LESS_THAN_ZERO) { | ||
| throw new RuntimeException(NEGATIVE_ID_EXCEPTION); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (id < LESS_THAN_ZERO) { | |
| throw new RuntimeException(NEGATIVE_ID_EXCEPTION); | |
| } |
| BigDecimal price = resultSet.getObject("price", BigDecimal.class); | ||
| return Optional.of(new Book(id, model, price)); | ||
| } | ||
| throw new RuntimeException(NO_BOOK_EXCEPTION + id); |
There was a problem hiding this comment.
Suggested change
| throw new RuntimeException(NO_BOOK_EXCEPTION + id); |
| if (resultSet.next()) { | ||
| String model = resultSet.getString("title"); | ||
| BigDecimal price = resultSet.getObject("price", BigDecimal.class); | ||
| return Optional.of(new Book(id, model, price)); |
There was a problem hiding this comment.
You can take out the book variable before the try block, then use book = new Book(your parsed fields) in the try block, and return optional.ofNullable(book) after the catch block
Comment on lines
94
to
96
| if (books.size() == ZERO) { | ||
| throw new RuntimeException(NO_RECORDS_EXCEPTION); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (books.size() == ZERO) { | |
| throw new RuntimeException(NO_RECORDS_EXCEPTION); | |
| } |
Comment on lines
89
to
91
| Long id = resultSet.getObject("id", Long.class); | ||
| String model = resultSet.getString("title"); | ||
| BigDecimal price = resultSet.getObject("price", BigDecimal.class); |
There was a problem hiding this comment.
You use this logic to parse book fields multiple times. Put it in a separate private method, something like
private Book parseBook(ResultSet resultSet)
return new Book(fields...)
Comment on lines
105
to
107
| if (book.getTitle() == null || book.getPrice() == null) { | ||
| throw new RuntimeException(NULL_FIELDS_EXCEPTION); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (book.getTitle() == null || book.getPrice() == null) { | |
| throw new RuntimeException(NULL_FIELDS_EXCEPTION); | |
| } |
…tro into jv-jdbc-intro
kozhukhovsky
approved these changes
Aug 6, 2023
Comment on lines
+19
to
+33
| // Book bookUpdated = bookDao.create(marquezBook); | ||
| // Book bookUpdated2 = bookDao.create(rowlingBook); | ||
| // System.out.println(bookUpdated); | ||
| // System.out.println(bookUpdated2); | ||
| // | ||
| // Optional<Book> bookById = bookDao.findById(3L); | ||
| // System.out.println(bookById); | ||
| // | ||
| // List<Book> allBooks = bookDao.findAll(); | ||
| // for (Book element : allBooks) { | ||
| // System.out.println(element); | ||
| // } | ||
| // | ||
| // Book updateBook = bookDao.update(rowlingBook); | ||
| // System.out.println(updateBook); |
There was a problem hiding this comment.
I just forgot to uncomment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.