implemented dao, connected to db, tested all of this in main #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikname2303
approved these changes
Mar 29, 2024
src/main/java/mate/academy/Main.java
Outdated
| public static void main(String[] args) { | ||
| BookDao bookDao = (BookDao) injector.getInstance(BookDao.class); | ||
|
|
||
| Book book1 = new Book("Book #1", BigDecimal.valueOf(10)); |
There was a problem hiding this comment.
why book1?
Oh, at first I added several books, and then I decided to leave only one and forgot to rename it, I'll have to do that, thanks
karma-o
suggested changes
Apr 2, 2024
Comment on lines
26
to
27
| statement.setString(1, book.getTitle()); | ||
| statement.setBigDecimal(2, book.getPrice()); |
There was a problem hiding this comment.
magic numbers, check other methods as well
Comment on lines
116
to
118
| Long id = resultSet.getLong("id"); | ||
| String title = resultSet.getString("title"); | ||
| BigDecimal price = resultSet.getBigDecimal("price"); |
|
|
||
| ResultSet resultSet = statement.getGeneratedKeys(); | ||
| if (resultSet.next()) { | ||
| book = new Book(resultSet.getLong(1), book.getTitle(), book.getPrice()); |
Comment on lines
50
to
53
| String title = resultSet.getString("title"); | ||
| BigDecimal price = resultSet.getBigDecimal("price"); | ||
|
|
||
| Book book = new Book(id, title, price); |
| BigDecimal price = resultSet.getBigDecimal("price"); | ||
|
|
||
| Book book = new Book(id, title, price); | ||
| return Optional.of(book); |
There was a problem hiding this comment.
you can check the difference in behavior with the null if you want 😉
Suggested change
| return Optional.of(book); | |
| return Optional.ofNullable(book); |
| } | ||
|
|
||
| private static Book getBook(ResultSet resultSet) throws SQLException { | ||
| Long id = resultSet.getLong("id"); |
There was a problem hiding this comment.
check the common mistakes on that getLong()
Comment on lines
15
to
16
| DB_PROPERTIES.put("user", "root"); | ||
| DB_PROPERTIES.put("password", "$miskPass@"); |
src/main/resources/init_db.sql
Outdated
| `id` BIGINT AUTO_INCREMENT PRIMARY KEY, | ||
| `title` VARCHAR(255) NOT NULL, | ||
| `price` decimal NOT NULL | ||
| ) |
| try { | ||
| Class.forName(DRIVER); | ||
| } catch (ClassNotFoundException e) { | ||
| throw new RuntimeException("Can not load JDBC driver" + DRIVER, e); |
There was a problem hiding this comment.
Suggested change
| throw new RuntimeException("Can not load JDBC driver" + DRIVER, e); | |
| throw new RuntimeException("Can not load JDBC driver: " + DRIVER, e); | |
Comment on lines
25
to
27
| public static Connection getConnection() throws SQLException { | ||
| return DriverManager.getConnection(DB_URL, DB_PROPERTIES); | ||
| } |
There was a problem hiding this comment.
let's use try/catch here to get the error closer to it's reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.