Jv jdbc intro hw solution #319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karma-o
suggested changes
Apr 1, 2024
|
|
||
| public class Book { | ||
| private Long id; | ||
|
|
src/main/resources/init_db.sql
Outdated
| @@ -0,0 +1,6 @@ | |||
| CREATE TABLE `books` ( | |||
| `id` INT NOT NULL AUTO_INCREMENT, | |||
There was a problem hiding this comment.
Suggested change
| `id` INT NOT NULL AUTO_INCREMENT, | |
| `id` BIGINT NOT NULL AUTO_INCREMENT, |
| public class BookDaoImpl implements BookDao { | ||
| @Override | ||
| public Book create(Book book) { | ||
| String sql = "INSERT INTO books(title, price) VALUES (?, ?)"; |
There was a problem hiding this comment.
this var could use a better naming, same in other places
|
|
||
| int affectedRows = statement.executeUpdate(); | ||
| if (affectedRows < 1) { | ||
| throw new RuntimeException("Expected to insert at least one row"); |
| book.setId(id); | ||
| } | ||
| } catch (SQLException e) { | ||
| throw new RuntimeException("Cannot save data", e); |
Comment on lines
49
to
55
| Long bookId = resultSet.getLong("id"); | ||
| String title = resultSet.getString("title"); | ||
| BigDecimal price = resultSet.getBigDecimal("price"); | ||
| Book book = new Book(); | ||
| book.setId(bookId); | ||
| book.setTitle(title); | ||
| book.setPrice(price); |
There was a problem hiding this comment.
code duplication, extract a private method parseBook() from it
Comment on lines
49
to
51
| Long bookId = resultSet.getLong("id"); | ||
| String title = resultSet.getString("title"); | ||
| BigDecimal price = resultSet.getBigDecimal("price"); |
Comment on lines
93
to
95
| statement.setString(1, book.getTitle()); | ||
| statement.setBigDecimal(2, book.getPrice()); | ||
| statement.setLong(3, book.getId()); |
There was a problem hiding this comment.
magic numbers, check other methods as well
| int rowsDeleted = statement.executeUpdate(); | ||
| return rowsDeleted > 0; | ||
| } catch (SQLException e) { | ||
| throw new DataProcessingException("Failed to delete book with id: " + id + e); |
There was a problem hiding this comment.
Suggested change
| throw new DataProcessingException("Failed to delete book with id: " + id + e); | |
| throw new DataProcessingException("Failed to delete book with id: " + id, e); |
| } | ||
| return book; | ||
| } catch (SQLException e) { | ||
| throw new DataProcessingException("Failed to update book with id: " + book.getId() + e); |
There was a problem hiding this comment.
same here, we should pass it as a separate parameter, because we need the whole original exception info, like stack trace and it's message to be saved, and passed ll the way to the user or dev
karma-o
reviewed
Apr 1, 2024
src/main/resources/init_db.sql
Outdated
| CREATE TABLE `books` ( | ||
| `id` INT NOT NULL AUTO_INCREMENT, | ||
| `bookTitle` VARCHAR(50), | ||
| `price` BIGINT, |
There was a problem hiding this comment.
price can be like 10.99, does integer allow any value after point?
yevheniisynytsia
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.