bookDao methods implemented and tested #343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
May 6, 2024
src/main/resources/init_db.sql
Outdated
| @@ -0,0 +1,5 @@ | |||
| CREATE TABLE `books` ( | |||
| `id` BIGINT AUO_INCREMENT PRIMARY KEY, | |||
| `title` VARCHAR(255), | |||
| import java.sql.SQLException; | ||
| import java.util.Properties; | ||
|
|
||
| public class ConnectionUtil { |
| PreparedStatement statement = connection.prepareStatement(sql)) { | ||
| statement.setLong(1, id); | ||
|
|
||
| int affectedRows = statement.executeUpdate(); |
There was a problem hiding this comment.
Suggested change
| int affectedRows = statement.executeUpdate(); | |
| return statement.executeUpdate() > 0; |
| + " inserted 0 rows", null); | ||
| } | ||
| } catch (SQLException e) { | ||
| throw new DataProcessingException("Failed to add new book: " + book, e); |
| int affectedRows = statement.executeUpdate(); | ||
| if (affectedRows < 1) { | ||
| throw new DataProcessingException("Expected to insert at least 1 row," | ||
| + " inserted 0 rows", null); |
There was a problem hiding this comment.
Don't put null, create other constructor public DataProcessingException(String message) if needed
| try (Connection connection = ConnectionUtil.getConnection(); | ||
| PreparedStatement statement = connection.prepareStatement(sql)) { | ||
| statement.setLong(1, id); | ||
| try (ResultSet resultSet = statement.executeQuery()) { |
Elena-Bruyako
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.