jdbc-intro-v1 #349

MaksimSokur · 2024-05-11T16:07:54Z

Establish connection to my DB

using community version of Idea - download plugin DB Browser (танці з бубном трохи) - it is work;
create new schema - books;

Create init_db.sql file and put the script.
Create Book model
Create DAO layer for Book model.
- create();
- findAll();
- findById();
- update();
- deleteById();
Used Dao annotation;
Return Optional findById;
Call CRUD methods in main.
Using custom exception

1. Establish connection to my DB - using community version of Idea - download plugin DB Browser (танці з бубном трохи) - it is work; - create new schema - books; 2. Create init_db.sql file and put the script. 3. Create Book model 4. Create DAO layer for Book model. - create(); - findAll(); - findById(); - update(); - deleteById(); 5. Used Dao annotation; 6. Return Optional findById; 7. Call CRUD methods in main. 8. Using custom exception

Elena-Bruyako · 2024-05-12T05:50:03Z

src/main/java/mate/academy/dao/BookDaoInt.java

+import mate.academy.lib.Dao;
+import mate.academy.model.Book;
+
+@Dao


This annotation should be there

Elena-Bruyako · 2024-05-12T05:50:09Z

src/main/java/mate/academy/dao/BookDaoInt.java

+import mate.academy.model.Book;
+
+@Dao
+public interface BookDaoInt {


Suggested change

public interface BookDaoInt {

public interface BookDao {

Elena-Bruyako · 2024-05-12T05:50:14Z

src/main/java/mate/academy/dao/BookDaoInt.java

+
+@Dao
+public interface BookDaoInt {
+


Suggested change

Elena-Bruyako · 2024-05-12T05:50:31Z

src/main/java/mate/academy/model/Book.java

+import java.math.BigDecimal;
+
+public class Book {
+


Suggested change

Elena-Bruyako · 2024-05-12T05:52:01Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+import java.util.Optional;
+import mate.academy.model.Book;
+
+public class BookDaoImpl implements BookDaoInt {


Suggested change

public class BookDaoImpl implements BookDaoInt {

@Dao

public class BookDaoImpl implements BookDaoInt {

Elena-Bruyako · 2024-05-12T06:02:35Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+        return books;
+    }
+
+    private Book mapBookFromResultSet(ResultSet resultSet) {


private methods should be placed after all public and protected methods

Elena-Bruyako · 2024-05-12T06:02:56Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+            book.setPrice(resultSet.getBigDecimal("price"));
+            return book;
+        } catch (SQLException e) {
+            throw new RuntimeException("SQL error db book.", e);


unclear message

Elena-Bruyako · 2024-05-12T06:03:55Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+                return Optional.of(mapBookFromResultSet(resultSet));
+            }
+        } catch (SQLException e) {
+            throw new RuntimeException("Sql error while finding book",e);


Suggested change

throw new RuntimeException("Sql error while finding book",e);

throw new DataProcessingException("Can't find a book by id: " + id, e);

Check all places

I Have a problem - cannot find symbol class DataProcessingExcepton
File -> Invalidate Caches/Restart - doing

DataProcessingExcepton is custom exception, that you can create. It' better to use instead of RuntimeException

Elena-Bruyako · 2024-05-12T06:05:18Z

src/main/java/mate/academy/Main.java

+import java.util.Optional;
+import mate.academy.dao.BookDaoImpl;
+import mate.academy.model.Book;
+
 public class Main {
    public static void main(String[] args) {


Suggested change

public static void main(String[] args) {

private static final Injector injector = Injector.getInstance("mate.academy");

public static void main(String[] args) {

Elena-Bruyako · 2024-05-12T06:05:29Z

src/main/java/mate/academy/Main.java

 public class Main {
    public static void main(String[] args) {
+        final BookDaoImpl bookDao = new BookDaoImpl();


Suggested change

final BookDaoImpl bookDao = new BookDaoImpl();

BookDao bookDao = (BookDao) injector.getInstance(BookDao.class);

corrected

Elena-Bruyako

Please make sure your build was successful before submitting a review request for your PR.

Elena-Bruyako · 2024-05-13T05:17:49Z

src/main/java/mate/academy/dao/BookDao.java

+import mate.academy.lib.Dao;
+import mate.academy.model.Book;
+
+@Dao


Suggested change

@Dao

This annotation shouldn't be here

Elena-Bruyako · 2024-05-13T05:18:06Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+    @Override
+    public Book create(Book book) {
+        String query = "INSERT INTO books (title, price) VALUES (?, ?)";
+        try (Connection connection = DriverManager.getConnection(URL, USER, PASSWORD)) {


Please, pay attention to the comment

Elena-Bruyako · 2024-05-13T05:18:22Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+    public Book create(Book book) {
+        String query = "INSERT INTO books (title, price) VALUES (?, ?)";
+        try (Connection connection = DriverManager.getConnection(URL, USER, PASSWORD)) {
+            PreparedStatement preparedStatement =


Please, pay attention to the comment

Elena-Bruyako · 2024-05-13T05:18:33Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+            preparedStatement.setString(1, book.getTitle());
+            preparedStatement.setBigDecimal(2, book.getPrice());
+            int updatedRows = preparedStatement.executeUpdate();
+            if (updatedRows == 0) {


Elena-Bruyako · 2024-05-13T05:18:43Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+            }
+            ResultSet generatedKeys = preparedStatement.getGeneratedKeys();
+            if (generatedKeys.next()) {
+                book.setId(generatedKeys.getLong(1));


Elena-Bruyako · 2024-05-13T05:18:58Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+        List<Book> books = new ArrayList<>();
+        String query = "SELECT * FROM books";
+        try (Connection connection = DriverManager.getConnection(URL, USER, PASSWORD)) {
+            Statement statement = connection.createStatement();


Create costom exeption DataProcessingException and using it Create Conction util and using it fixed the mistakes corrected

Elena-Bruyako · 2024-05-15T05:25:07Z

src/main/java/mate/academy/util/ConnectionUtil.java

+        return DriverManager.getConnection(DB_URL, DB_PROPERTIES);
+    }
+}
+


Try to not leave useless blank lines

Elena-Bruyako suggested changes May 12, 2024

View reviewed changes

jdbc-intro-v2

fe85939

corrected

MaksimSokur requested a review from Elena-Bruyako May 12, 2024 16:52

Elena-Bruyako suggested changes May 13, 2024

View reviewed changes

jdbc-intro-v3

20b1311

Create costom exeption DataProcessingException and using it Create Conction util and using it fixed the mistakes corrected

MaksimSokur requested a review from Elena-Bruyako May 14, 2024 18:23

Elena-Bruyako approved these changes May 15, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

jdbc-intro-v1 #349

jdbc-intro-v1 #349

MaksimSokur commented May 11, 2024

Elena-Bruyako May 12, 2024

Elena-Bruyako May 12, 2024

Elena-Bruyako May 12, 2024

Elena-Bruyako May 12, 2024

Elena-Bruyako May 12, 2024

Elena-Bruyako May 12, 2024

Elena-Bruyako May 12, 2024

Elena-Bruyako May 12, 2024

MaksimSokur May 12, 2024

Elena-Bruyako May 13, 2024

Elena-Bruyako May 12, 2024

Elena-Bruyako May 12, 2024

Elena-Bruyako left a comment

Elena-Bruyako May 13, 2024

Elena-Bruyako May 13, 2024

Elena-Bruyako May 13, 2024

Elena-Bruyako May 13, 2024

Elena-Bruyako May 13, 2024

Elena-Bruyako May 13, 2024

Elena-Bruyako May 15, 2024

	public class BookDaoImpl implements BookDaoInt {
	@Dao
	public class BookDaoImpl implements BookDaoInt {

	throw new RuntimeException("Sql error while finding book",e);
	throw new DataProcessingException("Can't find a book by id: " + id, e);

	final BookDaoImpl bookDao = new BookDaoImpl();
	BookDao bookDao = (BookDao) injector.getInstance(BookDao.class);

jdbc-intro-v1 #349

Are you sure you want to change the base?

jdbc-intro-v1 #349

Conversation

MaksimSokur commented May 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Elena-Bruyako left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment