Solved task jv-jdbc-intro: #351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASelivonchyk
commented
May 14, 2024
ASelivonchyk
commented
- implemented BookDao class with CRUD operations to retrieve needed data from DB;
- created util class - ConnectionUtil to establish connection with DB;
- added DbException and DataProcessingException as custom exceptions;
- all application constants moved for separate Constants class;
- used app.properties file for common variables;
- edited init_db.sql for creating DB schema and table;
- in pom.xml added necessary dependency;
- implemented BookDao class with CRUD operations to retrieve needed data from DB; - created util class - ConnectionUtil to establish connection with DB; - added DbException and DataProcessingException as custom exceptions; - all application constants moved for separate Constants class; - used app.properties file for common variables; - edited init_db.sql for creating DB schema and table; - in pom.xml added necessary dependency;
Elena-Bruyako
suggested changes
May 15, 2024
| .prepareStatement(SAVE_BOOK_QUERY, Statement.RETURN_GENERATED_KEYS)) { | ||
| createBookStatement.setString(1, book.getTitle()); | ||
| createBookStatement.setBigDecimal(2, book.getPrice()); | ||
| createBookStatement.executeUpdate(); |
There was a problem hiding this comment.
Do you need to check affected rows?
| package mate.academy.exception; | ||
|
|
||
| public class DataProcessingException extends RuntimeException { | ||
|
|
| import mate.academy.exception.DbException; | ||
|
|
||
| public class ConnectionUtil { | ||
| private static final Properties dbProperties = new Properties(); |
There was a problem hiding this comment.
Suggested change
| private static final Properties dbProperties = new Properties(); | |
| private static final Properties DB_PROPERTIES = new Properties(); |
constant naming convention
| package mate.academy.exception; | ||
|
|
||
| public class DbException extends RuntimeException { | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.