Task: jv-jdbc-intro. Executor: Oleksii Bashkirov. #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created DAO layer for Book model with save, findById, findAll, update and deleteById methods. Also created helper methods executeUpdate and executeQuery to reduce code duplication. And created two func.interfaces SqlConsumer and SqlFunction in the util package. Created a service layer with CRUD methods. Created custom exception. Also connected to Database(book_storage). Created new table (books) for this task. Created init_db.sql file in src/main/resources folder and put the scripts for creating required table. Used the @dao annotation on the BookDaoImpl class Edited the Main class.
Vasul-Pankiv
approved these changes
May 22, 2024
Comment on lines
+22
to
+45
| private static final String SAVE_SQL = """ | ||
| INSERT INTO books (title, price) | ||
| VALUES(?, ?) | ||
| """; | ||
| private static final String UPDATE_SQL = """ | ||
| UPDATE books | ||
| SET title = ?, price = ? | ||
| WHERE id = ? | ||
| """; | ||
| private static final String FIND_BY_ID_SQL = """ | ||
| SELECT id, title, price | ||
| FROM books | ||
| WHERE id = ? | ||
| """; | ||
| private static final String FIND_ALL_SQL = """ | ||
| SELECT id, | ||
| title, | ||
| price | ||
| FROM books | ||
| """; | ||
| private static final String DELETE_BY_ID_SQL = """ | ||
| DELETE FROM books | ||
| WHERE id = ? | ||
| """; |
There was a problem hiding this comment.
In such case, you can move Sqls to a separate file
Comment on lines
+77
to
+78
| return executeQuery(FIND_ALL_SQL, ps -> { | ||
| }, rs -> { |
There was a problem hiding this comment.
Suggested change
| return executeQuery(FIND_ALL_SQL, ps -> { | |
| }, rs -> { | |
| return executeQuery(FIND_ALL_SQL, ps -> {}, rs -> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Book model.
Created DAO layer for Book model with save, findById, findAll, update and deleteById methods. Also created helper methods executeUpdate and executeQuery to reduce code duplication. And created two func.interfaces SqlConsumer and SqlFunction in the util package. Created a service layer with CRUD methods.
Created custom exception.
Also connected to Database(book_storage).
Created new table (books) for this task.
Created init_db.sql file in src/main/resources folder and put the scripts for creating required table. Used the @dao annotation on the BookDaoImpl class
Edited the Main class.