resolve jdbc-intro #356
resolve jdbc-intro #356
Conversation
| statement.setBigDecimal(2, book.getPrice()); | ||
| statement.setLong(3, book.getId()); | ||
|
|
||
| int rowsAffected = statement.executeUpdate(); |
There was a problem hiding this comment.
| int rowsAffected = statement.executeUpdate(); | |
| if (affectedRows < 1) {..... |
There was a problem hiding this comment.
not fixed, throw exception in this situation, please don't ignore comments - if you disagree or don't understand them, ask in chat on the platform
| System.out.println("Rows updated: " + rowsAffected); | ||
| return book; | ||
| } catch (SQLException e) { | ||
| throw new DataProcessingException("Can not find all books", e); |
| System.out.println("Rows deleted: " + rowsAffected); | ||
| return rowsAffected > 0; | ||
| } catch (SQLException e) { | ||
| throw new DataProcessingException("Can not find all books", e); |
|
|
||
| statement.setLong(1, id); | ||
|
|
||
| int rowsAffected = statement.executeUpdate(); |
There was a problem hiding this comment.
| int rowsAffected = statement.executeUpdate(); | |
| return statement.executeUpdate() > 0; |
| try (Connection connection = ConnectionUtil.getConnection(); | ||
| PreparedStatement statement = connection.prepareStatement(sql)) { | ||
|
|
||
| int rowsAffected = statement.executeUpdate(); |
| System.out.println("Deleted " + rowsAffected + " rows from table books"); | ||
| return rowsAffected > 0; | ||
| } catch (SQLException e) { | ||
| throw new DataProcessingException("Can not delete all books", e); |
| import java.util.Properties; | ||
| import mate.academy.exception.DataProcessingException; | ||
|
|
||
| public class ConnectionUtil { |
There was a problem hiding this comment.
it's better to create util package and replace it there
src/main/java/mate/academy/Main.java
Outdated
|
|
||
| private static void testCreate() { | ||
| System.out.println("\nCREATE"); | ||
| Book bookHarry = new Book("Harry", new BigDecimal(1222)); |
There was a problem hiding this comment.
Let's create List books = List.of(new Book(.... and use it in books.stream().map(...
src/main/java/mate/academy/Main.java
Outdated
|
|
||
| private static void testFindAll() { | ||
| System.out.println("\nFIND ALL"); | ||
| for (var book : service.findAllBooks()) { |
There was a problem hiding this comment.
service.findAllBooks().stream().forEach(System.out::println);
src/main/java/mate/academy/Main.java
Outdated
| BookDao bookDao = (BookDao) injector.getInstance(BookDao.class); | ||
| service = new BookServiceImpl(bookDao); | ||
|
|
||
| testCreate(); |
There was a problem hiding this comment.
rename methods or don't create separate methods
| statement.setBigDecimal(2, book.getPrice()); | ||
| statement.setLong(3, book.getId()); | ||
|
|
||
| int rowsAffected = statement.executeUpdate(); |
There was a problem hiding this comment.
not fixed, throw exception in this situation, please don't ignore comments - if you disagree or don't understand them, ask in chat on the platform
| statement.setLong(3, book.getId()); | ||
|
|
||
| int rowsAffected = statement.executeUpdate(); | ||
| System.out.println("Rows updated: " + rowsAffected); |
No description provided.