Mydb #358
Open
Mydb #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuzan
suggested changes
May 27, 2024
kerrrusha
suggested changes
May 28, 2024
pom.xml
Outdated
There was a problem hiding this comment.
revert this. we should keep 1 blank line at the EOF
| } | ||
| return Optional.empty(); | ||
| } catch (SQLException e) { | ||
| throw new RuntimeException("Failed to find a book by id", e); |
| preparedStatement.setLong(1, id); | ||
| return preparedStatement.executeUpdate() > 0; | ||
| } catch (SQLException e) { | ||
| throw new RuntimeException("Failed to delete a book by id", e); |
src/main/resources/init_db.sql
Outdated
| title VARCHAR(255), | ||
| price INT, | ||
| PRIMARY KEY(id) | ||
| ); |
| try { | ||
| Class.forName("com.mysql.cj.jdbc.Driver"); | ||
| } catch (ClassNotFoundException e) { | ||
| throw new RuntimeException("Can not lod JDBC driver", e); |
There was a problem hiding this comment.
Suggested change
| throw new RuntimeException("Can not lod JDBC driver", e); | |
| throw new RuntimeException("Can not load JDBC driver", e); |
Elena-Bruyako
suggested changes
May 29, 2024
| public static void main(String[] args) { | ||
| BookDao bookDao = (BookDao) INJECTOR.getInstance(BookDao.class); | ||
|
|
There was a problem hiding this comment.
Let's create list of books here
Suggested change
| List<Book> books = List.of( | |
| new Book(... |
src/main/java/mate/academy/Main.java
Outdated
| bookDao.create(BOOK_2); | ||
| bookDao.create(BOOK_3); | ||
|
|
||
| bookDao.update(BOOK_1_UPDATE); |
There was a problem hiding this comment.
return updated book and print it
src/main/java/mate/academy/Main.java
Outdated
| public class Main { | ||
| private static final Injector INJECTOR = Injector.getInstance("mate.academy"); | ||
| private static final Book BOOK_1 = new Book("OnePiece", new BigDecimal(195)); |
| PreparedStatement.RETURN_GENERATED_KEYS)) { | ||
| preparedStatement.setString(1, book.getTitle()); | ||
| preparedStatement.setBigDecimal(2, book.getPrice()); | ||
| preparedStatement.executeUpdate(); |
There was a problem hiding this comment.
Suggested change
| preparedStatement.executeUpdate(); | |
| int affectedRows = statement.executeUpdate(); | |
| if (affectedRows < 1) { | |
| throw new DataProcessingException( | |
| "Expected to insert at least 1 row, but 0 was inserted"); | |
| } |
| preparedStatement.executeUpdate(); | ||
| ResultSet resultSet = preparedStatement.getGeneratedKeys(); | ||
| if (resultSet.next()) { | ||
| book.setId(resultSet.getLong(1)); |
There was a problem hiding this comment.
Suggested change
| book.setId(resultSet.getLong(1)); | |
| Long id = generatedKeys.getObject(1, Long.class); | |
| book.setId(id); |
Check common mistakes file
| preparedStatement.setString(1, book.getTitle()); | ||
| preparedStatement.setBigDecimal(2, book.getPrice()); | ||
| preparedStatement.setLong(3, book.getId()); | ||
| preparedStatement.executeUpdate(); |
There was a problem hiding this comment.
Suggested change
| preparedStatement.executeUpdate(); | |
| int affectedRows = statement.executeUpdate(); | |
| if (affectedRows < 1) { | |
| throw new DataProcessingException( | |
| "Expected to update at least 1 row, but 0 was updated."); | |
| } |
| import java.util.Properties; | ||
|
|
||
| public class ConnectionUtil { | ||
| private static final String DB_URL = "jdbc:mysql:" |
There was a problem hiding this comment.
Suggested change
| private static final String DB_URL = "jdbc:mysql:" | |
| private static final String DB_URL = "jdbc:mysql://localhost:3306/mydatabase?serverTimezone=UTC"; |
any concatenation creating new String object.
| } | ||
| return book; | ||
| } catch (SQLException e) { | ||
| throw new RuntimeException("Failed to create a book", e); |
There was a problem hiding this comment.
Suggested change
| throw new RuntimeException("Failed to create a book", e); | |
| throw new DataProcessingException("Failed to create a book", e); |
Check all places and use DataProcessingException
MentorMateAcademy
suggested changes
May 29, 2024
| PreparedStatement.RETURN_GENERATED_KEYS)) { | ||
| preparedStatement.setString(1, book.getTitle()); | ||
| preparedStatement.setBigDecimal(2, book.getPrice()); | ||
| preparedStatement.executeUpdate(); |
Comment on lines
20
to
22
| try (Connection connection = ConnectionUtil.getConnection(); | ||
| PreparedStatement preparedStatement = connection.prepareStatement(query, | ||
| PreparedStatement.RETURN_GENERATED_KEYS)) { |
There was a problem hiding this comment.
Try with resources use only in read operations
Comment on lines
78
to
79
| try (Connection connection = ConnectionUtil.getConnection(); | ||
| PreparedStatement preparedStatement = connection.prepareStatement(query)) { |
There was a problem hiding this comment.
The same with Try-w-resources
Comment on lines
8
to
13
| public class ConnectionUtil { | ||
| private static final String DB_URL = | ||
| "jdbc:mysql://localhost:3306/mydatabase?serverTimezone=UTC"; | ||
| private static final Properties DB_PROPERTIES; | ||
|
|
||
| static { |
There was a problem hiding this comment.
You class should has only one instance
Elena-Bruyako
suggested changes
May 30, 2024
Comment on lines
20
to
22
| try (Connection connection = ConnectionUtil.getConnection(); | ||
| PreparedStatement preparedStatement = connection.prepareStatement(query, | ||
| PreparedStatement.RETURN_GENERATED_KEYS)) { |
| PreparedStatement.RETURN_GENERATED_KEYS)) { | ||
| preparedStatement.setString(1, book.getTitle()); | ||
| preparedStatement.setBigDecimal(2, book.getPrice()); | ||
| preparedStatement.executeUpdate(); |
Comment on lines
78
to
79
| try (Connection connection = ConnectionUtil.getConnection(); | ||
| PreparedStatement preparedStatement = connection.prepareStatement(query)) { |
| preparedStatement.setString(1, book.getTitle()); | ||
| preparedStatement.setBigDecimal(2, book.getPrice()); | ||
| preparedStatement.setLong(3, book.getId()); | ||
| preparedStatement.executeUpdate(); |
MentorMateAcademy
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.