Hw jv jdbc intro #359
Open
Hw jv jdbc intro #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuzan
suggested changes
May 28, 2024
|
|
||
| private Book createBook(ResultSet resultSet) throws SQLException { | ||
| return new Book( | ||
| resultSet.getLong("id"), |
src/main/resources/init_db.sql
Outdated
| title VARCHAR(255) NOT NULL, | ||
| price DECIMAL(6, 2) NOT NULL, | ||
| is_deleted TINYINT NOT NULL DEFAULT 0 | ||
| )ENGINE=InnoDB DEFAULT CHARSET=utf8mb3; |
There was a problem hiding this comment.
Suggested change
| )ENGINE=InnoDB DEFAULT CHARSET=utf8mb3; | |
| )ENGINE=InnoDB DEFAULT CHARSET=utf8mb3; | |
|
|
||
| @Override | ||
| public boolean deleteById(Long id) { | ||
| String deletedQuery = "UPDATE books SET is_deleted = 1 WHERE id = ?"; |
Elena-Bruyako
suggested changes
May 29, 2024
src/main/java/mate/academy/Main.java
Outdated
| public class Main { | ||
| private static final Injector injector = Injector.getInstance("mate.academy"); | ||
| private static final BookDao bookDao = (BookDao) injector.getInstance(BookDao.class); |
There was a problem hiding this comment.
Suggested change
| private static final BookDao bookDao = (BookDao) injector.getInstance(BookDao.class); |
| public class Main { | ||
| private static final Injector injector = Injector.getInstance("mate.academy"); | ||
| private static final BookDao bookDao = (BookDao) injector.getInstance(BookDao.class); | ||
|
|
||
| public static void main(String[] args) { |
There was a problem hiding this comment.
Suggested change
| public static void main(String[] args) { | |
| public static void main(String[] args) { | |
| BookDao bookDao = (BookDao) injector.getInstance(BookDao.class); |
| insertQuery, Statement.RETURN_GENERATED_KEYS)) { | ||
| statement.setString(1, book.getTitle()); | ||
| statement.setBigDecimal(2, book.getPrice()); | ||
| statement.executeUpdate(); |
There was a problem hiding this comment.
Suggested change
| statement.executeUpdate(); | |
| int affectedRows = statement.executeUpdate(); | |
| if (affectedRows < 1) { | |
| throw new DataProcessingException( | |
| "Expected to insert at least 1 row, but 0 was inserted"); | |
| } |
| PreparedStatement statement = connection.prepareStatement(updateQuery)) { | ||
| statement.setString(1, book.getTitle()); | ||
| statement.setBigDecimal(2, book.getPrice()); | ||
| statement.setLong(3, id); |
There was a problem hiding this comment.
Suggested change
| statement.setLong(3, id); | |
| statement.setLong(3, book.getId()); |
| public Book update(Book book) { | ||
| String updateQuery = "UPDATE books SET title = ?, price = ? " | ||
| + "WHERE id = ? AND is_deleted = FALSE"; | ||
| Long id = book.getId(); |
There was a problem hiding this comment.
Suggested change
| Long id = book.getId(); |
| statement.setString(1, book.getTitle()); | ||
| statement.setBigDecimal(2, book.getPrice()); | ||
| statement.setLong(3, id); | ||
| int affectedRows = statement.executeUpdate(); |
There was a problem hiding this comment.
Suggested change
| int affectedRows = statement.executeUpdate(); | |
| int affectedRows = statement.executeUpdate(); | |
| if (affectedRows < 1) { | |
| throw new DataProcessingException( | |
| "Expected to update at least 1 row, but 0 was updated."); | |
| } |
| } catch (SQLException e) { | ||
| throw new DataProcessingException(CANT_UPDATE + id, e); | ||
| } | ||
| throw new DataProcessingException(CANT_FIND_BY_ID + id); |
There was a problem hiding this comment.
Suggested change
| throw new DataProcessingException(CANT_FIND_BY_ID + id); | |
| return book; |
| try (Connection connection = ConnectionUtil.getConnection(); | ||
| PreparedStatement statement = connection.prepareStatement(deletedQuery)) { | ||
| statement.setLong(1, id); | ||
| return statement.executeUpdate() != 0; |
There was a problem hiding this comment.
Suggested change
| return statement.executeUpdate() != 0; | |
| return statement.executeUpdate() > 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.