Implemented BookDao with connection to the DB #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vasul-Pankiv
suggested changes
Jun 4, 2024
Comment on lines
52
to
58
| String title = resultSet.getString("title"); | ||
| BigDecimal price = resultSet.getObject("price", BigDecimal.class); | ||
| Book book = new Book(); | ||
| book.setId(id); | ||
| book.setTitle(title); | ||
| book.setPrice(price); | ||
| return Optional.of(book); |
There was a problem hiding this comment.
move extracting book from resultSet to separate method and reuse it
src/main/resources/init_db.sql
Outdated
| `title` VARCHAR (255), | ||
| `price` INT, | ||
| PRIMARY KEY (`id`) | ||
| ); |
Elena-Bruyako
suggested changes
Jun 5, 2024
| import mate.academy.model.Book; | ||
|
|
||
| @Dao | ||
|
|
| @Override | ||
| public Book create(Book book) { | ||
| String sql = "INSERT INTO books (title, price) VALUE (?, ?)"; | ||
| try (Connection connection = ConnectionUtil.getConnection(); |
There was a problem hiding this comment.
Use try with resources only for read operations
src/main/resources/init_db.sql
Outdated
| CREATE TABLE `books` ( | ||
| `id` BIGINT NOT NULL AUTO_INCREMENT, | ||
| `title` VARCHAR (255), | ||
| `price` INT, |
There was a problem hiding this comment.
Use DECIMAL or NUMERIC for BigDecimal value
src/main/resources/init_db.sql
Outdated
| @@ -0,0 +1,6 @@ | |||
| CREATE TABLE `books` ( | |||
| `id` BIGINT NOT NULL AUTO_INCREMENT, | |||
There was a problem hiding this comment.
Actually MySQL declares primary key as NOT NULL automatically
PRIMARY KEY
A unique index where all key columns must be defined as NOT NULL. If they are not explicitly declared as NOT NULL, MySQL declares them so implicitly (and silently).
Elena-Bruyako
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.