created connection to DB and implemented DAO methods #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Jul 5, 2024
src/main/resources/init_db.sql
Outdated
| CREATE TABLE books ( | ||
| id BIGINT NOT NULL AUTO_INCREMENT, | ||
| title VARCHAR(255), | ||
| price INT, |
There was a problem hiding this comment.
Suggested change
| price INT, | |
| price DECIMAL(10, 2) NOT NULL |
src/main/resources/init_db.sql
Outdated
| @@ -0,0 +1,6 @@ | |||
| CREATE TABLE books ( | |||
| id BIGINT NOT NULL AUTO_INCREMENT, | |||
There was a problem hiding this comment.
Suggested change
| id BIGINT NOT NULL AUTO_INCREMENT, | |
| id BIGINT AUTO_INCREMENT, | |
| } | ||
| } | ||
|
|
||
| private Book createNewEntity(ResultSet resultSet) throws SQLException { |
There was a problem hiding this comment.
Suggested change
| private Book createNewEntity(ResultSet resultSet) throws SQLException { | |
| private Book mapResultSetToBook(ResultSet resultSet) throws SQLException { | |
MAMentorFX
approved these changes
Jul 10, 2024
| String sql = "SELECT * FROM books"; | ||
| List<Book> allBooks = new ArrayList<>(); | ||
| try (Connection connection = ConnectionUtil.create(); | ||
| PreparedStatement statement = connection.prepareStatement(sql)) { |
There was a problem hiding this comment.
It's more efficient to use Stetament instead of PreparedStatement if there are no ?-parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.