Hw 23 solution #382
Open
Hw 23 solution #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`DataProcessingException`, `Book`, `BookServiceImpl`. Created Interfaces: `BookDao`, `ConnectionUtil`, `Entity`, `id`, `Table` and `BookService`. Edit Class `Main`.
…`DataProcessingException`, `Book`, `BookServiceImpl`. Created Interfaces: `BookDao`, `ConnectionUtil`, `Entity`, `Table` and `BookService`. Edit Class `Main`.
…`DataProcessingException`, `Book`, `BookServiceImpl`. Created Interfaces: `BookDao`, `ConnectionUtil`, `Entity`, `Table` and `BookService`. Edit Class `Main`.
MAMentorFX
approved these changes
Jul 10, 2024
src/main/java/mate/academy/Main.java
Outdated
| Map.of("Java", new BigDecimal(300), | ||
| "Python", new BigDecimal(200), | ||
| "C++", new BigDecimal(100)) | ||
| .forEach((key, value) -> { |
There was a problem hiding this comment.
Suggested change
| .forEach((key, value) -> { | |
| .forEach((title, price) -> { |
| @Override | ||
| public List<Book> findAll() { | ||
| String sql = "SELECT * FROM books"; | ||
| try (PreparedStatement prepareStatement = ConnectionUtilImpl.getConnection() |
There was a problem hiding this comment.
Suggested change
| try (PreparedStatement prepareStatement = ConnectionUtilImpl.getConnection() | |
| try (Statement prepareStatement = ConnectionUtilImpl.getConnection() |
It's more efficient to use Statement, if there are no ?-parameters
|
|
||
| @Override | ||
| public Book update(Book book) { | ||
| String sql = "UPDATE books SET title = ?, price = ?) WHERE id = ?"; |
There was a problem hiding this comment.
Suggested change
| String sql = "UPDATE books SET title = ?, price = ?) WHERE id = ?"; | |
| String sql = "UPDATE books SET title = ?, price = ? WHERE id = ?"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created
init_db.sql, Classes:BookDaoImpl,ConnectionUtilImpl,DataProcessingException,Book,BookServiceImpl.Created Interfaces:
BookDao,ConnectionUtil,Entity,TableandBookService.Edit Class
Main.