Jbdc #384
Open
Jbdc #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Jul 14, 2024
| import java.math.BigDecimal; | ||
|
|
||
| public class Book { | ||
| private long id; |
There was a problem hiding this comment.
Suggested change
| private long id; | |
| private Long id; |
| Long id = resultSet.getObject("id", Long.class); | ||
| String title = resultSet.getString("title"); | ||
| BigDecimal price = resultSet.getBigDecimal("price"); | ||
| Book selectedBook = new Book(); |
There was a problem hiding this comment.
Suggested change
| Book selectedBook = new Book(); | |
| Book book = new Book(); |
src/main/resources/init_db.sql
Outdated
| CREATE DATABASE 'books_db'; | ||
|
|
||
| CREATE TABLE 'books' ( | ||
| 'id' BIGINT PRIMARY KEY NOT NULL AUTO_INCREMENT, |
There was a problem hiding this comment.
Suggested change
| 'id' BIGINT PRIMARY KEY NOT NULL AUTO_INCREMENT, | |
| 'id' BIGINT PRIMARY KEY AUTO_INCREMENT, |
MySQL automatically add not null and unique when you declare id as PK
Elena-Bruyako
suggested changes
Jul 15, 2024
src/main/java/mate/academy/Main.java
Outdated
| public class Main { | ||
| public static void main(String[] args) { | ||
| private static Injector injector = Injector.getInstance("mate.academy"); |
There was a problem hiding this comment.
Suggested change
| private static Injector injector = Injector.getInstance("mate.academy"); | |
| private static final Injector injector = Injector.getInstance("mate.academy"); |
| return Optional.of(book); | ||
| } | ||
| } catch (SQLException e) { | ||
| throw new DataProcessingException("Can ot find book by id" + id, e); |
There was a problem hiding this comment.
Suggested change
| throw new DataProcessingException("Can ot find book by id" + id, e); | |
| throw new DataProcessingException("Can not find book by id" + id, e); |
Elena-Bruyako
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.