created UtilConnection; #398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create init_ds.sql on resources folder; created entity Book; created Dao; used Injector;
Elena-Bruyako
suggested changes
Aug 20, 2024
README.md
Outdated
| @@ -25,7 +25,7 @@ public class Main { | |||
| } | |||
| ``` | |||
| **WARNING!!!** Path to your project must contain only english letters. Also, it mustn't contain spaces. In other case `Injector` won't work correctly. | |||
| - Your table should be named `books` and contain these columns: `id`, `title`, `price`. | |||
| - Your table should be named `book` and contain these columns: `id`, `title`, `price`. | |||
There was a problem hiding this comment.
but i have table dook with columns: id, title and price
There was a problem hiding this comment.
according to the naming convention, table in DB should be plural
checklist.md
Outdated
| @@ -3,7 +3,7 @@ | |||
| * Try to avoid code duplication. Especially, when you are working with ResultSet. | |||
| Move retrieving data from ResultSet into Entity object to a separate private method. | |||
|
|
|||
| * Don't make `books.title` UNIQUE. This is not required in this task. | |||
There was a problem hiding this comment.
Please, revert changes in checklist file. If you have some questions please ask in chat
| statement.setObject(1, id, Types.BIGINT); | ||
| ResultSet resultSet = statement.executeQuery(); | ||
| if (resultSet.next()) { | ||
| String title = resultSet.getObject("title", String.class); |
There was a problem hiding this comment.
replace logic of mapping resultSet to book into separate method
| List<Book> books = new ArrayList<>(); | ||
| ResultSet resultSet = statement.executeQuery(); | ||
| while (resultSet.next()) { | ||
| Book book = new Book(); |
There was a problem hiding this comment.
use separate method from comment above
Comment on lines
114
to
119
| int affectedRows = statement.executeUpdate(); | ||
| if (affectedRows < 1) { | ||
| throw new DataProcessingException("At least one row was expected to be affected, " | ||
| + "but 0 rows were affected"); | ||
| } | ||
| return true; |
There was a problem hiding this comment.
Suggested change
| int affectedRows = statement.executeUpdate(); | |
| if (affectedRows < 1) { | |
| throw new DataProcessingException("At least one row was expected to be affected, " | |
| + "but 0 rows were affected"); | |
| } | |
| return true; | |
| return statement.executeUpdate() > 0; |
Elena-Bruyako
suggested changes
Aug 21, 2024
README.md
Outdated
| @@ -25,7 +25,7 @@ public class Main { | |||
| } | |||
| ``` | |||
| **WARNING!!!** Path to your project must contain only english letters. Also, it mustn't contain spaces. In other case `Injector` won't work correctly. | |||
| - Your table should be named `books` and contain these columns: `id`, `title`, `price`. | |||
| - Your table should be named `book` and contain these columns: `id`, `title`, `price`. | |||
There was a problem hiding this comment.
according to the naming convention, table in DB should be plural
checklist.md
Outdated
| @@ -3,7 +3,7 @@ | |||
| * Try to avoid code duplication. Especially, when you are working with ResultSet. | |||
| Move retrieving data from ResultSet into Entity object to a separate private method. | |||
|
|
|||
| * Don't make `books.title` UNIQUE. This is not required in this task. | |||
There was a problem hiding this comment.
Please, revert changes in checklist file. If you have some questions please ask in chat
src/main/resources/init_db.sql
Outdated
| @@ -0,0 +1,5 @@ | |||
| CREATE TABLE book ( | |||
There was a problem hiding this comment.
Suggested change
| CREATE TABLE book ( | |
| CREATE TABLE books ( |
renamed table in db(now books, was book);
Elena-Bruyako
approved these changes
Aug 22, 2024
| @@ -17,9 +17,9 @@ public class Main { | |||
|
|
|||
| public static void main(String[] args) { | |||
| BookDao bookDao = (BookDao) injector.getInstance(BookDao.class); | |||
| Book book = new Book(); | |||
| Book books = new Book(); | |||
There was a problem hiding this comment.
Suggested change
| Book books = new Book(); | |
| Book book = new Book(); |
| // initialize field values using setters or constructor | ||
| bookDao.create(book); | ||
| bookDao.create(books); |
There was a problem hiding this comment.
Suggested change
| bookDao.create(books); | |
| bookDao.create(book); |
| @@ -40,10 +40,10 @@ public class Book { | |||
| ``` | |||
|
|
|||
| ### BookDao methods: | |||
| - Book create(Book book); | |||
| - Book create(Book books); | |||
There was a problem hiding this comment.
Suggested change
| - Book create(Book books); | |
| - Book create(Book book); |
| - Optional<Book> findById(Long id); | ||
| - List<Book> findAll(); | ||
| - Book update(Book book); | ||
| - Book update(Book books); |
There was a problem hiding this comment.
Suggested change
| - Book update(Book books); | |
| - Book update(Book book); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create init_ds.sql on resources folder;
created entity Book;
created Dao;
used Injector;