Added task solution #408

Lessorg · 2024-09-09T15:52:57Z

No description provided.

mateacademy-ai-mentor

Thank you for submitting your Pull Request! There are some critical issues that need to be addressed before we can merge your code. Specifically, the incomplete DB_URL in the ConnectionUtil needs to be fixed to ensure proper database connectivity. Additionally, the exception handling can be improved by using more specific exceptions rather than a generic RuntimeException, and the update method's behavior should be adjusted to handle cases where no book is found. Keep up the good work, and once these changes are implemented, we'll be ready to approve your PR! 😊 Remember, these fixes are crucial for maintaining the functionality and security of your application.

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2024-09-09T15:53:35Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+    public Book create(Book book) {
+        String sql = "INSERT INTO books (title, price) VALUES (?, ?)";
+
+        try (PreparedStatement statement = ConnectionUtil.getConnection().prepareStatement(sql,
+                Statement.RETURN_GENERATED_KEYS)) {
+            statement.setString(1, book.getTitle());
+            statement.setBigDecimal(2, book.getPrice());
+
+            int affectedRows = statement.executeUpdate();
+
+            if (affectedRows == 0) {
+                throw new SQLException("Creating book failed, no rows affected.");
+            }
+
+            try (ResultSet generatedKeys = statement.getGeneratedKeys()) {
+                if (generatedKeys.next()) {
+                    book.setId(generatedKeys.getLong(1));
+                } else {
+                    throw new SQLException("Creating book failed, no ID obtained.");
+                }
+            }
+        } catch (SQLException e) {
+            throw new DataProcessingException("Can't create book " + book, e);
+        }
+
+        return book;


Use PreparedStatement over Statement for the create method, and save the query in a separate variable before the try block to maintain consistency and readability.

mateacademy-ai-mentor · 2024-09-09T15:53:35Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+    public Book create(Book book) {
+        String sql = "INSERT INTO books (title, price) VALUES (?, ?)";
+
+        try (PreparedStatement statement = ConnectionUtil.getConnection().prepareStatement(sql,


You should close the PreparedStatement explicitly after use. The try-with-resources statement is already doing that, but it's a good practice to close it explicitly if you're going to reuse the connection.

mateacademy-ai-mentor · 2024-09-09T15:53:35Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+            int affectedRows = statement.executeUpdate();
+
+            if (affectedRows == 0) {


Instead of checking if affectedRows == 0, it's more flexible to check if affectedRows > 0 as it allows for batch updates where more than one row can be affected.

mateacademy-ai-mentor · 2024-09-09T15:53:35Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+                    Book book = new Book();
+                    book.setId(resultSet.getObject("id", Long.class));
+                    book.setPrice(resultSet.getObject("price", BigDecimal.class));
+                    book.setTitle(resultSet.getString("title"));


Avoid using both setters and constructors for initializing objects. Choose one approach for consistency. Also, consider moving ResultSet processing into a separate private method to avoid code duplication.

mateacademy-ai-mentor · 2024-09-09T15:53:35Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+            while (resultSet.next()) {
+                Book book = new Book();
+                book.setId(resultSet.getObject("id", Long.class));
+                book.setPrice(resultSet.getObject("price", BigDecimal.class));
+                book.setTitle(resultSet.getString("title"));
+                books.add(book);


As mentioned earlier, consider moving ResultSet processing into a separate private method to avoid code duplication.

mateacademy-ai-mentor · 2024-09-09T15:53:35Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+                }
+            }
+        } catch (SQLException e) {
+            throw new DataProcessingException("Can't create book " + book, e);


The exception message is good, it's informative and includes the book that failed to be created.

mateacademy-ai-mentor · 2024-09-09T15:53:35Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+                }
+            }
+        } catch (SQLException e) {
+            throw new DataProcessingException("Can't find by id for id = " + id, e);


The exception message is good, it's informative and includes the id that was not found.

mateacademy-ai-mentor · 2024-09-09T15:53:35Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+                        new RuntimeException());
+            }
+        } catch (SQLException e) {
+            throw new DataProcessingException("Can't update book with id = " + book.getId(), e);


The exception message is good, it's informative and includes the id of the book that failed to update.

mateacademy-ai-mentor · 2024-09-09T15:53:35Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+            statement.setLong(1, id);
+            return statement.executeUpdate() > 0;
+        } catch (SQLException e) {
+            throw new DataProcessingException("Can't delete book with id = " + id, e);


The exception message is good, it's informative and includes the id of the book that failed to be deleted.

mateacademy-ai-mentor · 2024-09-09T15:53:36Z

src/main/java/mate/academy/util/ConnectionUtil.java

+import java.util.Properties;
+
+public class ConnectionUtil {
+    private static final String DB_URL = "jdbc:mysql://localhost:3306/bookstore";


The DB_URL is not complete. It should contain the full JDBC URL, including the database name and other required parameters for the connection.

Elena-Bruyako · 2024-09-10T06:20:52Z

src/main/java/mate/academy/dao/BookDao.java

+import mate.academy.lib.Dao;
+import mate.academy.model.Book;
+
+@Dao


Suggested change

@Dao

without @dao annotation injector cant find class.

annotation Dao should be only under BookDaoImpl

Elena-Bruyako · 2024-09-10T06:21:18Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+@Dao
+public class BookDaoImpl implements BookDao {
+
+    public Book create(Book book) {


Add Override annotation (check all methods)

Elena-Bruyako · 2024-09-10T06:22:24Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+
+            int affectedRows = statement.executeUpdate();
+
+            if (affectedRows == 0) {


Suggested change

if (affectedRows == 0) {

if (affectedRows < 1) {

Elena-Bruyako · 2024-09-10T06:22:42Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+            int affectedRows = statement.executeUpdate();
+
+            if (affectedRows == 0) {
+                throw new SQLException("Creating book failed, no rows affected.");


Suggested change

throw new SQLException("Creating book failed, no rows affected.");

throw new DataProcessingException("Creating book failed, no rows affected.");

Elena-Bruyako · 2024-09-10T06:22:58Z

src/main/java/mate/academy/dao/BookDaoImpl.java

+
+            try (ResultSet generatedKeys = statement.getGeneratedKeys()) {
+                if (generatedKeys.next()) {
+                    book.setId(generatedKeys.getLong(1));


Suggested change

book.setId(generatedKeys.getLong(1));

Long id = generatedKeys.getObject(1, Long.class);

book.setId(id);

Elena-Bruyako · 2024-09-10T06:24:48Z

src/main/resources/init_db.sql

+USE BookStore;
+
+CREATE TABLE Books (
+    id BIGINT NOT NULL AUTO_INCREMENT,


Suggested change

id BIGINT NOT NULL AUTO_INCREMENT,

id BIGINT AUTO_INCREMENT,

Elena-Bruyako · 2024-09-10T14:50:56Z

src/main/java/mate/academy/dao/BookDao.java

+import mate.academy.lib.Dao;
+import mate.academy.model.Book;
+
+@Dao


annotation Dao should be only under BookDaoImpl

Added task solution

74e7a1c

mateacademy-ai-mentor suggested changes Sep 9, 2024

View reviewed changes

Added Ai suggested fixes

0e821cd

Lessorg requested a review from mateacademy-ai-mentor September 9, 2024 16:09

Elena-Bruyako suggested changes Sep 10, 2024

View reviewed changes

Added bug fixes

0908b61

Lessorg requested a review from Elena-Bruyako September 10, 2024 08:57

Elena-Bruyako suggested changes Sep 10, 2024

View reviewed changes

Removed redunant @dao annotation

8e6b870

Lessorg requested a review from Elena-Bruyako September 10, 2024 19:25

Elena-Bruyako approved these changes Sep 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added task solution #408

Added task solution #408

Lessorg commented Sep 9, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Sep 9, 2024

mateacademy-ai-mentor Sep 9, 2024

mateacademy-ai-mentor Sep 9, 2024

mateacademy-ai-mentor Sep 9, 2024

mateacademy-ai-mentor Sep 9, 2024

mateacademy-ai-mentor Sep 9, 2024

mateacademy-ai-mentor Sep 9, 2024

mateacademy-ai-mentor Sep 9, 2024

mateacademy-ai-mentor Sep 9, 2024

mateacademy-ai-mentor Sep 9, 2024

Elena-Bruyako Sep 10, 2024

Lessorg Sep 10, 2024

Elena-Bruyako Sep 10, 2024

Elena-Bruyako Sep 10, 2024

Elena-Bruyako Sep 10, 2024

Elena-Bruyako Sep 10, 2024

Elena-Bruyako Sep 10, 2024

Elena-Bruyako Sep 10, 2024

Elena-Bruyako Sep 10, 2024

		int affectedRows = statement.executeUpdate();

		if (affectedRows == 0) {

	throw new SQLException("Creating book failed, no rows affected.");
	throw new DataProcessingException("Creating book failed, no rows affected.");

	book.setId(generatedKeys.getLong(1));
	Long id = generatedKeys.getObject(1, Long.class);
	book.setId(id);

Added task solution #408

Are you sure you want to change the base?

Added task solution #408

Conversation

Lessorg commented Sep 9, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment