Create BookDao interface, MySqlBookDao class #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create Book, DataProcessingException, MySqlConnectionManager classes
keda-vlad
suggested changes
Aug 10, 2023
Comment on lines
24
to
30
| public static Connection getConnection() { | ||
| try { | ||
| return DriverManager.getConnection(DB_URL, DB_PROPERTIES); | ||
| } catch (SQLException e) { | ||
| throw new RuntimeException("Cannot get connection", e); | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe you shouldn't catch it there, for me looks better to catch this in Dao in try-with-resources
|
|
||
| @Override | ||
| public String toString() { | ||
| return "Book{" + |
src/main/java/mate/academy/Main.java
Outdated
| public class Main { | ||
| public static final Injector injector = Injector.getInstance("mate.academy"); |
Comment on lines
8
to
12
| Book create(Book book); | ||
| Optional<Book> findById(Long id); | ||
| List<Book> findAll(); | ||
| Book update(Book book); | ||
| boolean deleteById(Long id); |
There was a problem hiding this comment.
Empty lines should be between methods
keda-vlad
approved these changes
Aug 11, 2023
andrii-hoienko
suggested changes
Aug 11, 2023
src/main/java/mate/academy/Main.java
Outdated
| public class Main { | ||
| public static final Injector INJECTOR = Injector.getInstance("mate.academy"); |
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { |
There was a problem hiding this comment.
Do you use hachCode and equals somewhere?
| try (Connection connection = MySqlConnectionManager.getConnection(); | ||
| PreparedStatement statement = connection.prepareStatement(query, | ||
| Statement.RETURN_GENERATED_KEYS)) { | ||
| statement.setString(1, book.getTitle()); |
| Statement.RETURN_GENERATED_KEYS)) { | ||
| statement.setString(1, book.getTitle()); | ||
| statement.setBigDecimal(2, book.getPrice()); | ||
| if (statement.executeUpdate() < 1) { |
|
|
||
| @Override | ||
| public Book update(Book book) { | ||
| String query = """ |
There was a problem hiding this comment.
Looks like too much quotes, it is better to make this query in one line or make all queries like this to be consistent
| statement.setString(1, book.getTitle()); | ||
| statement.setBigDecimal(2, book.getPrice()); | ||
| statement.setLong(3, book.getId()); | ||
| if (statement.executeUpdate() < 1) { |
vovasalyha
suggested changes
Aug 15, 2023
| Statement.RETURN_GENERATED_KEYS)) { | ||
| statement.setString(TITLE_PARAMETER_INDEX, book.getTitle()); | ||
| statement.setBigDecimal(PRICE_PARAMETER_INDEX, book.getPrice()); | ||
| if (statement.executeUpdate() < ONE_AFFECTED_ROW) { |
There was a problem hiding this comment.
Actually, it's a very rare case when you can receive 0 affected rows on insert, not sure if this check is very useful.
| PreparedStatement statement = connection.prepareStatement(query)) { | ||
| statement.setString(TITLE_PARAMETER_INDEX, book.getTitle()); | ||
| statement.setBigDecimal(PRICE_PARAMETER_INDEX, book.getPrice()); | ||
| statement.setLong(UPDATE_ID_PARAMETER_INDEX, book.getId()); |
| } | ||
|
|
||
| private Book parseToObject(ResultSet resultSet) throws SQLException { | ||
| long id = resultSet.getObject(ID_ROW_LABEL, Long.class); |
There was a problem hiding this comment.
If you are expecting that null can appear then NPE can be thrown here.
Suggested change
| long id = resultSet.getObject(ID_ROW_LABEL, Long.class); | |
| Long id = resultSet.getObject(ID_ROW_LABEL, Long.class); |
andrii-hoienko
suggested changes
Aug 15, 2023
| @@ -17,43 +17,11 @@ | |||
| https://raw.githubusercontent.com/mate-academy/style-guides/master/java/checkstyle.xml | |||
| </maven.checkstyle.plugin.configLocation> | |||
| </properties> | |||
|
|
|||
| <build> | |||
vovasalyha
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Book, DataProcessingException, MySqlConnectionManager classes