added BookDao and connected project to db #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irynamekh
approved these changes
Aug 11, 2023
nacenik
suggested changes
Aug 14, 2023
Comment on lines
8
to
12
| Book create(Book book); | ||
| Optional<Book> findById(Long id); | ||
| List<Book> findAll(); | ||
| Book update(Book book); | ||
| boolean deleteById(Long id); |
Comment on lines
26
to
30
| private static final String CREATE_QUERY = "INSERT INTO books (id, title, price) VALUES (?, ?, ?)"; | ||
| private static final String FIND_BY_ID_QUERY = "SELECT * FROM books WHERE id = ?"; | ||
| private static final String FIND_ALL_QUERY = "SELECT * FROM books"; | ||
| private static final String UPDATE_QUERY = "UPDATE books SET title = ?, price = ? WHERE id = ?"; | ||
| private static final String DELETE_QUERY = "DELETE FROM books WHERE id = ?"; |
There was a problem hiding this comment.
Create a query in the method where you will use it. Like method variable
| private static final String ID_COLUMN = "books.id"; | ||
| private static final String TITLE_COLUMN = "books.title"; | ||
| private static final String PRICE_COLUMN = "books.price"; | ||
| private static final String NO_UPDATES_EXCEPTION_TEXT = "Expected to insert at least 1 row, but inserted 0 rows."; |
There was a problem hiding this comment.
are you inserting rows during the update? Or do you just update values?
| private static final int TITLE_INDEX_FOR_UPDATE = 1; | ||
| private static final int PRICE_INDEX_FOR_UPDATE = 2; | ||
| private static final int ID_INDEX_FOR_UPDATE = 3; | ||
| private static final String CREATE_QUERY = "INSERT INTO books (id, title, price) VALUES (?, ?, ?)"; |
There was a problem hiding this comment.
The id is auto-generated. you don't need to set it up by your hand.
There was a problem hiding this comment.
It's not for updating “id” value, it's index of “id” column for update operation (“…WHERE id = ?”). But I'll rename it for better readability.
| } | ||
| } | ||
|
|
||
| private Book formBookFromQuery(ResultSet resultSet) throws SQLException{ |
There was a problem hiding this comment.
bad method name
Suggested change
| private Book formBookFromQuery(ResultSet resultSet) throws SQLException{ | |
| private Book parseBookFromQuery(ResultSet resultSet) throws SQLException{ |
| public DataProcessingException(String message, Throwable ex) { | ||
| super(message, ex); | ||
| } | ||
|
|
src/main/resources/init_db.sql
Outdated
| @@ -0,0 +1,3 @@ | |||
| CREATE DATABASE book_schema; | |||
| USE book_schema; | |||
| CREATE TABLE books (`id` BIGINT NOT NULL AUTO_INCREMENT, `title` VARCHAR(255), `price` DECIMAL, PRIMARY KEY (`id`)); | |||
There was a problem hiding this comment.
I'd recommend you put this query in separate lines. It's hard to read it.
… to methods variables, renamed update index's constants for better readability, renamed "formBookFromQuery()" into "parseBookFromQuery", removed redundant line in DataProcessingException, put query at init_db.sql in separate lines for better readability, changed NO_UPDATES_EXCEPTION_TEXT for greater correctness of the message
Vasul-Pankiv
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.