commit #6
Open
commit #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Rommelua
suggested changes
Aug 2, 2023
| book.setId(id); | ||
| } | ||
| } catch (SQLException e) { | ||
| throw new RuntimeException("Can't add book to db ", e); |
|
|
||
| @Override | ||
| public Optional<Book> findById(Long id) { | ||
| String query = "SELECT id, title, price " + "FROM books WHERE id = ?;"; |
There was a problem hiding this comment.
Suggested change
| String query = "SELECT id, title, price " + "FROM books WHERE id = ?;"; | |
| String query = "SELECT id, title, price FROM books WHERE id = ?;"; |
Comment on lines
82
to
83
| @Override | ||
| public boolean deleteById (Long id) { |
There was a problem hiding this comment.
Suggested change
| @Override | |
| public boolean deleteById (Long id) { | |
| @Override | |
| public boolean deleteById (Long id) { |
Comment on lines
67
to
68
| @Override | ||
| public Book update (Book book) { |
There was a problem hiding this comment.
Suggested change
| @Override | |
| public Book update (Book book) { | |
| @Override | |
| public Book update (Book book) { |
aaananas
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.