implemented task #63
Open
implemented task #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visqe
suggested changes
Aug 14, 2023
src/main/java/mate/academy/Main.java
Outdated
Comment on lines
17
to
19
| bookDao.create(book); | ||
| Long bookId = 1L; | ||
| Optional<Book> foundBook = bookDao.findById(bookId); |
There was a problem hiding this comment.
i think it is bad idea to find book by hardcoded id
Suggested change
| bookDao.create(book); | |
| Long bookId = 1L; | |
| Optional<Book> foundBook = bookDao.findById(bookId); | |
| Book createdBook = bookDao.create(book); | |
| Optional<Book> foundBook = bookDao.findById(ceatedBook.getId()); |
| PreparedStatement statement = connection.prepareStatement(CREATE_QUERY, | ||
| PreparedStatement.RETURN_GENERATED_KEYS)) { | ||
| setBookParameters(statement, book); | ||
| statement.executeUpdate(); |
There was a problem hiding this comment.
i think there should be
Suggested change
| statement.executeUpdate(); | |
| int updatedRows = statement.executeUpdate(); | |
| if(updatedRows < 1) { | |
| throw new DataProcassException ... |
| PreparedStatement statement = connection.prepareStatement(UPDATE_QUERY)) { | ||
| setBookParameters(statement, book); | ||
| statement.setLong(3, book.getId()); | ||
| statement.executeUpdate(); |
There was a problem hiding this comment.
i think there should be
Suggested change
| statement.executeUpdate(); | |
| int updatedRows = statement.executeUpdate(); | |
| if(updatedRows < 1) { | |
| throw new DataProcassException ... |
Vasul-Pankiv
suggested changes
Aug 14, 2023
Comment on lines
8
to
12
| Book create(Book book); | ||
| Optional<Book> findById(Long id); | ||
| List<Book> findAll(); | ||
| Book update(Book book); | ||
| boolean deleteById(Long id); |
There was a problem hiding this comment.
add empty lines between methods
also add empty line to the end of file
Comment on lines
19
to
23
| private static final String CREATE_QUERY = "INSERT INTO books (title, price) VALUES (?, ?)"; | ||
| private static final String FIND_BY_ID_QUERY = "SELECT * FROM books WHERE id = ?"; | ||
| private static final String FIND_ALL_QUERY = "SELECT * FROM books"; | ||
| private static final String UPDATE_QUERY = "UPDATE books SET title = ?, price = ? WHERE id = ?"; | ||
| private static final String DELETE_BY_ID_QUERY = "DELETE FROM books WHERE id = ?"; |
There was a problem hiding this comment.
make queries as local variables for method where you use it
Comment on lines
33
to
34
| throw new DataProcessingException("Failed to create book: no rows were updated."); | ||
| } |
Comment on lines
88
to
90
| if (updatedRows < 1) { | ||
| throw new DataProcessingException("Failed to create book: no rows were updated."); | ||
| } |
| } | ||
| try (ResultSet generatedKeys = statement.getGeneratedKeys()) { | ||
| if (generatedKeys.next()) { | ||
| book.setId(generatedKeys.getLong(1)); |
There was a problem hiding this comment.
see common mistakes how to get long values forom result set
| statement.setString(1, book.getTitle()); | ||
| statement.setBigDecimal(2, book.getPrice()); | ||
| } | ||
| } |
There was a problem hiding this comment.
add empty line to the end of file
| public void setPrice(BigDecimal price) { | ||
| this.price = price; | ||
| } | ||
| } |
There was a problem hiding this comment.
add empty line to the end of file
vovasalyha
approved these changes
Aug 14, 2023
| <version>8.1.0</version> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.