implemented CRUD operations #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nacenik
suggested changes
Aug 14, 2023
src/main/java/mate/academy/Main.java
Outdated
| //update | ||
| book.setTitle("JDBC for wood people, Part2"); | ||
| book.setPrice(BigDecimal.valueOf(500)); | ||
| book.setId(3L); |
There was a problem hiding this comment.
According to the query, you cannot change id for book.
Comment on lines
9
to
13
| Book create(Book book); | ||
| Optional<Book> findById(Long id); | ||
| List<Book> findAll(); | ||
| Book update(Book book); | ||
| boolean deleteById(Long id); |
Comment on lines
20
to
21
| statement.setString(1, book.getTitle()); | ||
| statement.setBigDecimal(2, book.getPrice()); |
There was a problem hiding this comment.
Magic numbers. Fix it in all places. Maybe you can reuse some of them :)
Comment on lines
23
to
26
| int affectedRows = statement.executeUpdate(); | ||
| if (affectedRows < 1) { | ||
| throw new RuntimeException("Expected to insert at least 1 row, but inserted 0 rows."); | ||
| } |
There was a problem hiding this comment.
You don't need to check affected rows here
| Book bookFromDb = null; | ||
| try (Connection connection = ConnectionUtil.getConnection(); | ||
| PreparedStatement statement = connection.prepareStatement(query)) { | ||
| statement.setLong(1, 3L); |
There was a problem hiding this comment.
what is that? Where do you search by the id that method gets?
Comment on lines
100
to
104
| int affectedRow = statement.executeUpdate(); | ||
| if (affectedRow < 1) { | ||
| throw new RuntimeException("Expected to delete at least 1 row but was 0."); | ||
| } | ||
| return affectedRow > 0; |
There was a problem hiding this comment.
you can delete 0 rows. Also, how are you expecting to get false in this method according to your solution?
Suggested change
| int affectedRow = statement.executeUpdate(); | |
| if (affectedRow < 1) { | |
| throw new RuntimeException("Expected to delete at least 1 row but was 0."); | |
| } | |
| return affectedRow > 0; | |
| return statement.executeUpdate() > 0; |
| } | ||
| return affectedRow > 0; | ||
| } catch (SQLException e) { | ||
| throw new DataProcessingException("Can not delete row by the id: " + id, e); |
| } | ||
|
|
||
| } catch (SQLException e) { | ||
| throw new DataProcessingException("Can not update row by the book with id: " + book.getId(), e); |
src/main/resources/init_db.sql
Outdated
| PRIMARY KEY (id) | ||
| ); | ||
|
|
||
| SHOW TABLES; |
src/main/resources/init_db.sql
Outdated
| @@ -0,0 +1,14 @@ | |||
| SHOW DATABASES; | |||
…ntro-homework # Conflicts: # pom.xml
vovasalyha
suggested changes
Aug 15, 2023
pom.xml
Outdated
| @@ -56,4 +62,4 @@ | |||
| </plugins> | |||
| </pluginManagement> | |||
| </build> | |||
| </project> | |||
| </project> | |||
There was a problem hiding this comment.
Do not forget about empty line at the end of files.
| book.setId(id); | ||
| } | ||
| } catch (SQLException e) { | ||
| throw new DataProcessingException("Can`t get a new Book: " + book, e); |
There was a problem hiding this comment.
Not resolved.
Suggested change
| throw new DataProcessingException("Can`t get a new Book: " + book, e); | |
| throw new DataProcessingException("Can`t create a new book: " + book, e); |
| try (Connection connection = ConnectionUtil.getConnection(); | ||
| PreparedStatement statement = connection.prepareStatement(query)) { | ||
| statement.setLong(1, 3L); | ||
|
|
Comment on lines
81
to
86
|
|
||
| int affectedRow = statement.executeUpdate(); | ||
| if (affectedRow < 1) { | ||
| throw new RuntimeException("Expected to update at least 1 row but was 0."); | ||
| } | ||
|
|
|
|
||
| private Book parseResultSetInBook(ResultSet resultSet) throws SQLException { | ||
| Book dbBook = new Book(); | ||
| dbBook.setId(resultSet.getLong("id")); |
| try { | ||
| Class.forName("com.mysql.cj.jdbc.Driver"); | ||
| } catch (ClassNotFoundException e) { | ||
| throw new RuntimeException(e); |
src/main/resources/init_db.sql
Outdated
| CREATE TABLE books ( | ||
| id BIGINT NOT NULL AUTO_INCREMENT, | ||
| title VARCHAR(255), | ||
| price INT, |
There was a problem hiding this comment.
Suggested change
| price INT, | |
| price DECIMAL, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.