added solution #81
added solution #81
Conversation
| public static Connection getConnection() throws SQLException { | ||
| return DriverManager.getConnection("jdbc:mysql://localhost:3306/booksDB", DB_Properties); | ||
| } | ||
| } |
There was a problem hiding this comment.
add empty line to the end of file
| Book update(Book book); | ||
|
|
||
| boolean deleteById(Long id); | ||
| } |
There was a problem hiding this comment.
add empty line to the end of file
| if (updates < 1) { | ||
| throw new DataProcessingException("Error during creating book " + book); | ||
| } |
There was a problem hiding this comment.
you do not need this check, affect zero rows - is okay
| if (updates < 1) { | ||
| throw new DataProcessingException("Error during updating book " + book); | ||
| } |
| public DataProcessingException(String message) { | ||
| super(message); | ||
| } | ||
| } |
There was a problem hiding this comment.
add empty line to the end of file
| ", price=" + price + | ||
| '}'; | ||
| } | ||
| } |
There was a problem hiding this comment.
add empty line to the end of file
| statement.setString(1, book.getTitle()); | ||
| statement.setBigDecimal(2, book.getPrice()); | ||
| statement.setLong(3, book.getId()); |
There was a problem hiding this comment.
Create constants for magic numbers and reuse them
| statement.setLong(3, book.getId()); | ||
| statement.executeUpdate(); | ||
| } catch (SQLException e) { | ||
| throw new DataProcessingException("Can not update book in table", e); |
| @@ -0,0 +1,26 @@ | |||
| package mate.academy; | |||
There was a problem hiding this comment.
I'd recommend you create separate package for util classes
| book.setId(resultSet.getObject(1, Long.class)); | ||
| } | ||
| } catch (SQLException e) { | ||
| throw new DataProcessingException("Cant save book with title = " + book.getTitle(), e); |
There was a problem hiding this comment.
print all info about book that cannot be saved
| statement.setLong(1, id); | ||
| return statement.executeUpdate() > 0; | ||
| } catch (SQLException e) { | ||
| throw new RuntimeException("Can not delete book by id " + id, e); |
There was a problem hiding this comment.
| throw new RuntimeException("Can not delete book by id " + id, e); | |
| throw new RuntimeException("Cannot delete book by id " + id, e); |
src/main/resources/init_db.sql
Outdated
| CREATE TABLE `books` ( | ||
| `id` INT NOT NULL AUTO_INCREMENT, | ||
| `title` VARCHAR(255), | ||
| `price` INT, |
There was a problem hiding this comment.
Int? How do you want to put a big decimal into the int?
No description provided.