Fulfilled all the conditions of the task. Created classes of figures,… #1751

Jacalius · 2024-11-28T01:55:55Z

… interfaces and implemented methods.

mateacademy-ai-mentor

Thank you for your hard work on this Pull Request! 😊 While your code is mostly well-implemented, there are a few critical issues that need to be addressed before we can approve it:

Method Naming: There is a typo in the method name getRundomFigure() in the FigureSupplier class. It should be corrected to getRandomFigure() to ensure consistency and avoid confusion.
Variable Naming: The IsoscelesTrapezoid class has a typo in the field name hight. This should be corrected to height to maintain clarity and correctness.
Type Safety: Across several classes, consider using the Color enum instead of a String for the color parameter. This change will improve type safety and maintain consistency with the rest of your code.
Method Implementation: In the RightTriangle class, the draw() method incorrectly labels the shape as 'Rectangle'. Please correct this to 'RightTriangle' to accurately reflect the class functionality.

These changes are important to ensure your code is robust, maintainable, and aligned with the task requirements. Once you've addressed these issues, we can proceed with the approval. Keep up the great work, and don't hesitate to reach out if you need any help! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

mateacademy-ai-mentor · 2024-11-28T01:58:06Z

src/main/java/core/basesyntax/FigureSupplier.java

+    private ColorSupplier supplier = new ColorSupplier();
+    private Random random = new Random();
+
+    public Figure getRundomFigure() {


There is a typo in the method name getRundomFigure(). It should be corrected to getRandomFigure().

mateacademy-ai-mentor · 2024-11-28T01:58:06Z

src/main/java/core/basesyntax/FigureSupplier.java

+    private Random random = new Random();
+
+    public Figure getRundomFigure() {
+        String color = supplier.getRandomColor();


Instead of using String for color, consider using the Color enum directly to improve type safety and align with the task requirements.

mateacademy-ai-mentor · 2024-11-28T01:58:06Z

src/main/java/core/basesyntax/FigureSupplier.java

+    }
+
+    public Figure getDefaultFigure() {
+        return new Circle(DEFAULT_RADIUS, Color.WHITE.name());


When creating the default figure, consider passing the Color.WHITE enum directly instead of using Color.WHITE.name() to maintain consistency with the use of enums.

mateacademy-ai-mentor · 2024-11-28T01:58:06Z

src/main/java/core/basesyntax/IsoscelesTrapezoid.java

+public class IsoscelesTrapezoid extends Figure {
+    private int bottomBase;
+    private int topBase;
+    private int hight;


The variable name hight is misspelled. It should be corrected to height.

mateacademy-ai-mentor · 2024-11-28T01:58:06Z

src/main/java/core/basesyntax/IsoscelesTrapezoid.java

+    private int topBase;
+    private int hight;
+
+    public IsoscelesTrapezoid(int bottomBase, int topBase, int hight, String color) {


Consider using the Color enum instead of a String for the color parameter to maintain type safety and consistency with the rest of the code.

mateacademy-ai-mentor · 2024-11-28T01:58:06Z

src/main/java/core/basesyntax/Main.java

+
+        for (int i = 0; i < figures.length; i++) {
+            if (i < figures.length / 2) {
+                figures[i] = figureSupplier.getRundomFigure();


There is a typo in the method call getRundomFigure(). It should be corrected to getRandomFigure() to match the method name in the FigureSupplier class.

mateacademy-ai-mentor · 2024-11-28T01:58:06Z

src/main/java/core/basesyntax/Rectangle.java

+    private int length;
+    private int width;
+
+    public Rectangle(int length, int width, String color) {


Consider using the Color enum instead of a String for the color parameter to maintain type safety and consistency with the rest of the code.

mateacademy-ai-mentor · 2024-11-28T01:58:06Z

src/main/java/core/basesyntax/RightTriangle.java

+    }
+
+    @Override
+    public void draw() {


The draw() method incorrectly labels the shape as 'Rectangle'. It should be corrected to 'RightTriangle'.

mateacademy-ai-mentor · 2024-11-28T01:58:06Z

src/main/java/core/basesyntax/RightTriangle.java

+    private int legA;
+    private int legB;
+
+    public RightTriangle(int legA, int legB, String color) {


Consider using the Color enum instead of a String for the color parameter to maintain type safety and consistency with the rest of the code.

mateacademy-ai-mentor · 2024-11-28T01:58:07Z

src/main/java/core/basesyntax/Square.java

+public class Square extends Figure {
+    private int side;
+
+    public Square(int side, String color) {


Consider using the Color enum instead of a String for the color parameter to maintain type safety and consistency with the rest of the code.

…ly from Enum.

mateacademy-ai-mentor

Great job on your submission! 🎉 Your code implementation mostly meets the task requirements, and you've made significant progress. Here are a few points to consider for improvement:

Typo Corrections:
- In the IsoscelesTrapezoid class, ensure that the field and parameter name hight is corrected to height throughout the class, including the constructor and the draw() method. This will enhance clarity and correctness.
- In the FigureSupplier class, the method name getRundomFigure() has been corrected to getRandomFigure(), which is great for consistency.
Area Calculation:
- Double-check the getArea() method in the IsoscelesTrapezoid class to ensure it uses the correct formula: ((bottomBase + topBase) / 2) * height.
Code Readability:
- Consider using separate variables for complex expressions passed to constructors to improve code readability, as suggested in the checklist.

Your efforts are commendable, and these adjustments will help you refine your skills further. Keep up the good work, and make sure to address these points in future projects to avoid similar issues. Happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2024-11-28T02:44:09Z

src/main/java/core/basesyntax/FigureSupplier.java

+    private ColorSupplier supplier = new ColorSupplier();
+    private Random random = new Random();
+
+    public Figure getRandomFigure() {


There is a typo in the method name getRundomFigure(). It should be corrected to getRandomFigure() to ensure consistency and avoid confusion.

mateacademy-ai-mentor · 2024-11-28T02:44:09Z

src/main/java/core/basesyntax/FigureSupplier.java

+            case 0 -> new Circle(randomSide, color);
+            case 1 -> new IsoscelesTrapezoid(randomSide, randomSide, randomSide, color);
+            case 2 -> new Rectangle(randomSide, randomSide, color);
+            case 3 -> new RightTriangle(randomSide, randomSide, color);
+            case 4 -> new Square(randomSide, color);


Consider creating separate variables for expressions passed to constructors for better code readability, as suggested in the checklist.

mateacademy-ai-mentor · 2024-11-28T02:44:09Z

src/main/java/core/basesyntax/IsoscelesTrapezoid.java

+public class IsoscelesTrapezoid extends Figure {
+    private int bottomBase;
+    private int topBase;
+    private int hight;


There is a typo in the field name hight. It should be corrected to height to maintain clarity and correctness.

mateacademy-ai-mentor · 2024-11-28T02:44:09Z

src/main/java/core/basesyntax/IsoscelesTrapezoid.java

+    public IsoscelesTrapezoid(int bottomBase, int topBase, int hight, Color color) {
+        this.bottomBase = bottomBase;
+        this.topBase = topBase;
+        this.hight = hight;


Ensure that the parameter name hight is corrected to height in the constructor as well.

mateacademy-ai-mentor · 2024-11-28T02:44:09Z

src/main/java/core/basesyntax/IsoscelesTrapezoid.java

+
+    @Override
+    public double getArea() {
+        return ((bottomBase + topBase) / 2) * hight;


Ensure that the calculation in getArea() is correct according to the formula for the area of an isosceles trapezoid: ((bottomBase + topBase) / 2) * height.

mateacademy-ai-mentor · 2024-11-28T02:44:10Z

src/main/java/core/basesyntax/IsoscelesTrapezoid.java

+    @Override
+    public void draw() {
+        System.out.println("IsoscelesTrapezoid, area: " + getArea() + " sq. units, bottomBase: "
+                + bottomBase + " units, topBase: " + topBase + " units, hight: " + hight


Ensure that the field name hight is corrected to height in the draw() method as well.

mateacademy-ai-mentor · 2024-11-28T02:44:10Z

src/main/java/core/basesyntax/RightTriangle.java

+    }
+
+    @Override
+    public void draw() {


Ensure that the draw() method correctly labels the shape as 'RightTriangle'.

Fulfilled all the conditions of the task. Created classes of figures,…

71b8dbf

… interfaces and implemented methods.

mateacademy-ai-mentor suggested changes Nov 28, 2024

View reviewed changes

Fixed grammatical errors and implemented the Color enumeration direct…

11059b8

…ly from Enum.

Jacalius requested a review from mateacademy-ai-mentor November 28, 2024 02:41

mateacademy-ai-mentor approved these changes Nov 28, 2024

View reviewed changes

Jacalius added 2 commits November 27, 2024 20:52

Fixed grammatical errors

b04ccc1

Fixed grammatical errors

d842b70

Jacalius requested a review from mateacademy-ai-mentor November 28, 2024 02:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fulfilled all the conditions of the task. Created classes of figures,… #1751

Fulfilled all the conditions of the task. Created classes of figures,… #1751

Jacalius commented Nov 28, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

mateacademy-ai-mentor Nov 28, 2024

Fulfilled all the conditions of the task. Created classes of figures,… #1751

Are you sure you want to change the base?

Fulfilled all the conditions of the task. Created classes of figures,… #1751

Conversation

Jacalius commented Nov 28, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment