added authentication service #1007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
everything fine? |
MAMentorFX
approved these changes
Mar 31, 2024
| return false; | ||
| } | ||
|
|
| @@ -15,6 +15,12 @@ public class UserService { | |||
| * Return <code>null</code> if there is no suitable user | |||
| */ | |||
| public User findByEmail(String email) { | |||
|
|
|||
Comment on lines
+19
to
+23
| for (int i = 0; i < users.length; i++) { | ||
| if (users[i].getEmail().equals(email)) { | ||
| return users[i]; | ||
| } | ||
| } |
There was a problem hiding this comment.
You can do like Map userEmailToPassword, to avoid O(n)
There was a problem hiding this comment.
I am confident that using a map can effectively optimize the code and speed up its compilation. However, I have not yet studied this in this course, so I cannot apply it. Most likely, this will be explained in the next topics, so do not consider my solution incorrect. I have removed the unnecessary lines you pointed out, as can be seen in the following commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.