implemented method findByEmail and method login #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Sep 25, 2024
| public boolean login(String email, String password) { | ||
| return false; | ||
| User user = UserService.findByEmail(email); |
There was a problem hiding this comment.
create an instanse of UserService
it should be class-level variabel
| @@ -14,7 +14,13 @@ public class UserService { | |||
| * @return - user if his email is equal to passed email. | |||
| * Return <code>null</code> if there is no suitable user | |||
| */ | |||
| public User findByEmail(String email) { | |||
|
|
|||
| public static User findByEmail(String email) { | |||
There was a problem hiding this comment.
Suggested change
| public static User findByEmail(String email) { | |
| public User findByEmail(String email) { |
Elena-Bruyako
suggested changes
Sep 25, 2024
| public boolean login(String email, String password) { | ||
| return false; | ||
| UserService userService = new UserService(); |
There was a problem hiding this comment.
in previous comment, I mentioned that UserService should be class-level variable
Now, you create new instanse of UserService each time when you call login method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.