Implementation of solution for jv-oop-lesson-0 #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Oct 16, 2024
Comment on lines
19
to
23
| if (user != null && user.getPassword().equals(password)) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (user != null && user.getPassword().equals(password)) { | |
| return true; | |
| } else { | |
| return false; | |
| } | |
| return user != null && user.getPassword().equals(password); |
| public User findByEmail(String email) { | ||
| return null; | ||
| return Arrays.stream(users) |
There was a problem hiding this comment.
stream works slower than for each, so for this particular task you can use for each loop
Elena-Bruyako
suggested changes
Oct 16, 2024
| @@ -11,6 +15,11 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| return false; | |||
| User user = userService.findByEmail(email); | |||
| if (user != null && user.getPassword().equals(password)) { | |||
There was a problem hiding this comment.
Suggested change
| if (user != null && user.getPassword().equals(password)) { | |
| return user != null && user.getPassword().equals(password); |
Elena-Bruyako
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.