generated from mate-academy/jv-homework-template
-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
виходить ошибка для джона ,і не розумію в чому проблема. #1122
Open
mixx1k
wants to merge
2
commits into
mate-academy:master
Choose a base branch
from
mixx1k:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 9 additions & 2 deletions
11
src/main/java/mate/academy/service/AuthenticationService.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,23 @@ | ||
package mate.academy.service; | ||
|
||
public class AuthenticationService { | ||
import mate.academy.model.User; | ||
|
||
public class AuthenticationService extends UserService { | ||
/** | ||
* Imagine that some user wants to login to your site. | ||
* You should check if user credentials (login and password) are valid or not. | ||
* All users are stored in <code>UserService</code> class. | ||
* @param email - user's email | ||
* | ||
* @param email - user's email | ||
* @param password - user's password | ||
* @return true if user by email exists and passed password is equal to user's password. | ||
* Return false in any other cases. | ||
*/ | ||
public boolean login(String email, String password) { | ||
User user = findByEmail(email); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you should create UserService instance. Think should it be class-level or local variable |
||
if (user != null) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's better to use ternary operator here |
||
return user.getPassword().equals(password); | ||
} | ||
return false; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,18 +3,26 @@ | |
import mate.academy.model.User; | ||
|
||
public class UserService { | ||
private static final User[] users = new User[] { | ||
private static final User[] users = new User[]{ | ||
new User("[email protected]", "1234"), | ||
new User("[email protected]", "1234") | ||
new User("[email protected]", "1234"), | ||
new User("[email protected]", "1234"), | ||
new User("[email protected]", "qwerty") | ||
}; | ||
|
||
/** | ||
* Find user by email. All users are stored in <code>private static final User[] users</code> | ||
* | ||
* @param email - the input parameter | ||
* @return - user if his email is equal to passed email. | ||
* Return <code>null</code> if there is no suitable user | ||
*/ | ||
public User findByEmail(String email) { | ||
for (User user : users) { | ||
if (user.getEmail().equals(email)) { | ||
return user; | ||
} | ||
} | ||
return null; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.