add verify #1153
Closed
add verify #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuzan
suggested changes
Dec 19, 2024
| @@ -14,7 +14,12 @@ public class UserService { | |||
| * @return - user if his email is equal to passed email. | |||
| * Return <code>null</code> if there is no suitable user | |||
| */ | |||
| public User findByEmail(String email) { | |||
| return null; | |||
| public static User findByEmail(String email) { | |||
There was a problem hiding this comment.
Suggested change
| public static User findByEmail(String email) { | |
| public User findByEmail(String email) { |
| public User findByEmail(String email) { | ||
| return null; | ||
| public static User findByEmail(String email) { | ||
| for (User u : users) { |
There was a problem hiding this comment.
Suggested change
| for (User u : users) { | |
| for (User user : users) { |
avoid short one-letter naming, readability is important
| return u; | ||
| } | ||
| } | ||
| return new User("NoNe", ""); |
There was a problem hiding this comment.
what should you return, if there is no match? read the comment again carefully
Comment on lines
14
to
16
| return UserService.findByEmail(email) | ||
| .getPassword() | ||
| .equals(password); |
There was a problem hiding this comment.
you will get NPE after refactoring UserService, so you'll need to make changes here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.