-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create HW #1157
base: master
Are you sure you want to change the base?
create HW #1157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's slightly improve your solution ;)
if (user == null) { | ||
return false; | ||
} else if (user.getPassword().equals(password)) { | ||
return true; | ||
} | ||
return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use ternary operator instead
.github/workflows/ci.yml
Outdated
- uses: actions/checkout@v2 | ||
- name: Set up JDK 11 | ||
- name: Set up JDK 17 | ||
uses: actions/setup-java@v2 | ||
with: | ||
java-version: '11' | ||
java-version: '17' | ||
distribution: 'adopt' | ||
cache: maven | ||
- name: Build with Maven |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not change CI files yourself
if (user == null) { | ||
return false; | ||
} else if (user.getPassword().equals(password)) { | ||
return true; | ||
} else { | ||
return false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (user == null) { | |
return false; | |
} else if (user.getPassword().equals(password)) { | |
return true; | |
} else { | |
return false; | |
} | |
return user != null && user.getPassword().equals(password); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
No description provided.