the requested methods have been implemented #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan95kos
suggested changes
Oct 15, 2023
Comment on lines
4
to
6
| private static final String BOB_EMAIL = "[email protected]"; | ||
| private static final String BOB_PASSWORD = "querty"; | ||
| private static final String DEFAULT_PASSWORD = "1234"; |
There was a problem hiding this comment.
useless constants
Suggested change
| private static final String BOB_EMAIL = "[email protected]"; | |
| private static final String BOB_PASSWORD = "querty"; | |
| private static final String DEFAULT_PASSWORD = "1234"; |
| @@ -11,6 +15,9 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| return false; | |||
| if (BOB_EMAIL.equalsIgnoreCase(email)) { | |||
There was a problem hiding this comment.
You should use the UserService here
UserService must be a class field
Please correct the task description to make it clear what exactly you are requesting to implement. Thank you!
Ivan95kos
suggested changes
Oct 15, 2023
| @@ -11,6 +14,8 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| return false; | |||
| UserService userService = new UserService(); | |||
There was a problem hiding this comment.
UserService must be a class field
Suggested change
| UserService userService = new UserService(); |
okuzan
approved these changes
Oct 16, 2023
| @@ -11,6 +15,7 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| return false; | |||
| User user = userService.findByEmail(email); | |||
| return (user != null && user.getPassword().equals(password)); | |||
There was a problem hiding this comment.
Suggested change
| return (user != null && user.getPassword().equals(password)); | |
| return user != null && user.getPassword().equals(password); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.