Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jv oop lesson 0 #731

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Jv oop lesson 0 #731

wants to merge 4 commits into from

Conversation

rk0v
Copy link

@rk0v rk0v commented Oct 15, 2023

No description provided.

@@ -15,6 +15,11 @@ public class UserService {
* Return <code>null</code> if there is no suitable user
*/
public User findByEmail(String email) {
for (User user : users) {
if (user.getEmail() == email) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use equals instead of ==

* @param password - user's password
* @return true if user by email exists and passed password is equal to user's password.
* Return false in any other cases.
*/
public boolean login(String email, String password) {
for (User user : UserService.users) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not use loop in this method

@rk0v rk0v requested a review from Rommelua October 17, 2023 11:32
* @param password - user's password
* @return true if user by email exists and passed password is equal to user's password.
* Return false in any other cases.
*/
public boolean login(String email, String password) {
return false;
UserService userService = new UserService();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

userService should be class field

return false;
UserService userService = new UserService();
User user = userService.findByEmail(email);
return user != null && user.getEmail().equals(email) && user.getPassword().equals(password);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return user != null && user.getEmail().equals(email) && user.getPassword().equals(password);
return user != null && user.getPassword().equals(password);

@rk0v rk0v requested a review from Rommelua October 17, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants