-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jv oop lesson 0 #731
base: master
Are you sure you want to change the base?
Jv oop lesson 0 #731
Conversation
@@ -15,6 +15,11 @@ public class UserService { | |||
* Return <code>null</code> if there is no suitable user | |||
*/ | |||
public User findByEmail(String email) { | |||
for (User user : users) { | |||
if (user.getEmail() == email) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use equals
instead of ==
* @param password - user's password | ||
* @return true if user by email exists and passed password is equal to user's password. | ||
* Return false in any other cases. | ||
*/ | ||
public boolean login(String email, String password) { | ||
for (User user : UserService.users) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not use loop in this method
* @param password - user's password | ||
* @return true if user by email exists and passed password is equal to user's password. | ||
* Return false in any other cases. | ||
*/ | ||
public boolean login(String email, String password) { | ||
return false; | ||
UserService userService = new UserService(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
userService should be class field
return false; | ||
UserService userService = new UserService(); | ||
User user = userService.findByEmail(email); | ||
return user != null && user.getEmail().equals(email) && user.getPassword().equals(password); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return user != null && user.getEmail().equals(email) && user.getPassword().equals(password); | |
return user != null && user.getPassword().equals(password); |
No description provided.