Added solution to method UserService and AuthenticationService #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rommelua
suggested changes
Oct 25, 2023
| @@ -11,6 +14,12 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| UserService service = new UserService(); | |||
| @@ -11,6 +14,12 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| UserService service = new UserService(); | |||
| Optional<User> user = Optional.ofNullable(service.findByEmail(email)); | |||
There was a problem hiding this comment.
No reason for using Optional here - it makes code more difficult
Optional is useful for method return type (like a warning - we possibly have null inside)
Replaced ref to UserService as a class field; Removed 'Optional'.
|
Replaced ref to UserService as a class field; |
Replaced ref to UserService as a class field; Removed Optional
Sanderfuck
suggested changes
Oct 27, 2023
Comment on lines
21
to
24
| if (user != null) { | ||
| return user.getPassword().equals(password); | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Simplify it in one line using one return, at first check user != null && condition for email
Sanderfuck
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.