implemented salary info method #1255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olekskov
suggested changes
Apr 4, 2024
| LocalDate localDateFrom = LocalDate.parse(dateFrom, formatter); | ||
| LocalDate localDateTo = LocalDate.parse(dateTo, formatter); | ||
| for (String name : names) { | ||
| result.append("\n"); |
There was a problem hiding this comment.
Please use operating system independent symbol for new line
Suggested change
| result.append("\n"); | |
| result.append(System.lineSeparator()); |
Comment on lines
27
to
30
| if ((entryDate.isEqual(localDateFrom) | ||
| || entryDate.isAfter(localDateFrom)) | ||
| && (entryDate.isEqual(localDateTo) | ||
| || entryDate.isBefore(localDateTo)) |
There was a problem hiding this comment.
Please use !entryDate.isAfter() and !entryDate.isBefore() to simlify expression by omitting isEqual conditions
| * Integer.parseInt(elements[INCOME_PER_HOURS_INDEX]); | ||
| } | ||
| } | ||
| result.append(name).append(SEPARATOR) |
There was a problem hiding this comment.
I'd move here append from line 22 to have all of them in one place
| private static final String HEADER = "Report for period "; | ||
| private static final String SEPARATOR = " - "; | ||
| private static final String DATA_SEPARATOR = " "; | ||
| private DateTimeFormatter formatter = DateTimeFormatter.ofPattern("dd.MM.yyyy"); |
There was a problem hiding this comment.
formatter is also not going to be changed
Suggested change
| private DateTimeFormatter formatter = DateTimeFormatter.ofPattern("dd.MM.yyyy"); | |
| private static final DateTimeFormatter formatter = DateTimeFormatter.ofPattern("dd.MM.yyyy"); |
okuzan
approved these changes
Apr 4, 2024
| result.append(System.lineSeparator()) | ||
| .append(name).append(SEPARATOR) | ||
| .append(moneyEarned); | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.