getSalaryInfo method was implemented #1259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerrrusha
suggested changes
Apr 10, 2024
Comment on lines
15
to
21
| LocalDate date; | ||
| String nameOfEmployee; | ||
| int hours; | ||
| int salaryPerHour; | ||
| int compareToDateFrom; | ||
| int compareToDateTo; | ||
| String[] personInformation; |
There was a problem hiding this comment.
declare it inline
Suggested change
| LocalDate date; | |
| String nameOfEmployee; | |
| int hours; | |
| int salaryPerHour; | |
| int compareToDateFrom; | |
| int compareToDateTo; | |
| String[] personInformation; |
Comment on lines
31
to
32
| compareToDateFrom = localDateFrom.compareTo(date); | ||
| compareToDateTo = localDateTo.compareTo(date); |
There was a problem hiding this comment.
just use isBefore and isAfter, it will improve your code readability
| finalSalary[List.of(names).indexOf(nameOfEmployee)] += hours * salaryPerHour; | ||
| } | ||
| } | ||
| return dataToString(names,finalSalary,dateFrom,dateTo); |
There was a problem hiding this comment.
Suggested change
| return dataToString(names,finalSalary,dateFrom,dateTo); | |
| return dataToString(names, finalSalary, dateFrom, dateTo); |
| resultString.append(String.format("Report for period %s - %s",dateFrom,dateTo)); | ||
| for (int i = 0; i < names.length; i++) { | ||
| resultString | ||
| .append(String.format(System.lineSeparator() + "%s - %d", names[i], salary[i])); |
There was a problem hiding this comment.
dont use String format, just use set of .append methods
| } | ||
| return resultString.toString(); | ||
| } | ||
|
|
There was a problem hiding this comment.
redundant blank line
Suggested change
|
I can't declarate variables inline, because maven checkstile fails |
kerrrusha
suggested changes
Apr 10, 2024
Comment on lines
15
to
19
| LocalDate date; | ||
| String nameOfEmployee; | ||
| int hours; | ||
| int salaryPerHour; | ||
| String[] personInformation; |
There was a problem hiding this comment.
not fixed. declare them inline
Suggested change
| LocalDate date; | |
| String nameOfEmployee; | |
| int hours; | |
| int salaryPerHour; | |
| String[] personInformation; |
|
|
||
| private String dataToString(String[] names, int[] salary, String dateFrom, String dateTo) { | ||
| StringBuilder resultString = new StringBuilder(); | ||
| resultString.append(String.format("Report for period %s - %s",dateFrom,dateTo)); |
| for (int i = 0; i < names.length; i++) { | ||
| resultString | ||
| .append(System.lineSeparator()) | ||
| .append(names[i]).append(" - ").append(salary[i]); |
Rommelua
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.