-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solved the task #1278
base: master
Are you sure you want to change the base?
Solved the task #1278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost done
private final DateTimeFormatter timeFormatter; | ||
|
||
public SalaryInfo() { | ||
timeFormatter = DateTimeFormatter.ofPattern(DATE_PATTERN); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can save it in constant
StringBuilder reportBuilder = new StringBuilder().append(REPORT_TITLE) | ||
.append(dateFrom) | ||
.append(SEPARATOR) | ||
.append(dateTo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StringBuilder reportBuilder = new StringBuilder().append(REPORT_TITLE) | |
.append(dateFrom) | |
.append(SEPARATOR) | |
.append(dateTo); | |
StringBuilder reportBuilder = new StringBuilder() | |
.append(REPORT_TITLE) | |
.append(dateFrom) | |
.append(SEPARATOR) | |
.append(dateTo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job!
No description provided.