Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved the task #1278

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

snowfallen
Copy link

No description provided.

Copy link

@MentorMA MentorMA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done

private final DateTimeFormatter timeFormatter;

public SalaryInfo() {
timeFormatter = DateTimeFormatter.ofPattern(DATE_PATTERN);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can save it in constant

Comment on lines 22 to 25
StringBuilder reportBuilder = new StringBuilder().append(REPORT_TITLE)
.append(dateFrom)
.append(SEPARATOR)
.append(dateTo);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
StringBuilder reportBuilder = new StringBuilder().append(REPORT_TITLE)
.append(dateFrom)
.append(SEPARATOR)
.append(dateTo);
StringBuilder reportBuilder = new StringBuilder()
.append(REPORT_TITLE)
.append(dateFrom)
.append(SEPARATOR)
.append(dateTo);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better

@snowfallen snowfallen requested a review from MentorMA May 16, 2024 14:29
Copy link

@okuzan okuzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants