Implement method to calculate employee salaries #1282
Conversation
There was a problem hiding this comment.
Nice try! Before creating a PR please go through all the common mistakes provided at the end of the task description, I left some comments, please implement them and then before re-requesting review make sure you don't make these most common mistakes.
https://github.com/mate-academy/jv-salary-info/blob/master/checklist.md
| return salaryMap; | ||
| } | ||
|
|
||
| private String print(Map<String, Integer> salaryMap, |
There was a problem hiding this comment.
This name is a little misleading, print usually means to print something on a console for example and don't return any value. Please change this name to something like createReport.
| public class SalaryInfo { | ||
| private final DateTimeFormatter formatter = DateTimeFormatter.ofPattern("dd.MM.yyyy"); |
There was a problem hiding this comment.
make it a constant (private static final)
| LocalDate startDate = parseDate(dateFrom); | ||
| LocalDate endDate = parseDate(dateTo); | ||
|
|
||
| Map<String, Integer> salaryMap = initializeSalaryMap(names); |
| StringBuilder result = new StringBuilder(); | ||
| result.append("Report for period ") | ||
| .append(dateFrom).append(" - ") | ||
| .append(dateTo).append("\n"); |
| LocalDate date = LocalDate.parse(parts[0], formatter); | ||
| String name = parts[1]; | ||
| int workHours = Integer.parseInt(parts[2]); | ||
| int perHourRate = Integer.parseInt(parts[3]); |
There was a problem hiding this comment.
Please try to do it with 2 loops, right now you use 2 normal for loops and one forEach on your map.
| } | ||
|
|
||
| } catch (Exception e) { | ||
| System.err.println("Invalid data entry: " + entry); |
There was a problem hiding this comment.
If you want to catch an exception here, you should re-throw some custom exception/use RuntimeException.
| System.err.println("Invalid data entry: " + entry); | |
| throw new RuntimeException("Invalid data entry: " + entry, e); |
No description provided.