Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a calculate for employees #1284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 42 additions & 1 deletion src/main/java/core/basesyntax/SalaryInfo.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,48 @@
package core.basesyntax;

import java.time.LocalDate;
import java.time.format.DateTimeFormatter;

public class SalaryInfo {
private static final int DATE_INDEX = 0;
private static final int NAME_INDEX = 1;
private static final int HOUR_INDEX = 2;
private static final int RATE_INDEX = 3;
private static final DateTimeFormatter DATE_FORMATTER
= DateTimeFormatter.ofPattern("dd.MM.yyyy");

public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) {
return null;
LocalDate fromDate = LocalDate.parse(dateFrom, DATE_FORMATTER);
LocalDate toDate = LocalDate.parse(dateTo, DATE_FORMATTER);

StringBuilder reportLines = new StringBuilder();
reportLines.append("Report for period ").append(dateFrom).append(" - ").append(dateTo);
for (String name : names) {
int earned = calculateEarnedSalary(name, data, fromDate, toDate);
reportLines.append(System.lineSeparator()).append(name).append(" - ").append(earned);
}
return reportLines.toString();
}

private int calculateEarnedSalary(String name, String[] data,
LocalDate fromDate, LocalDate toDate) {
int earned = 0;
for (String entry : data) {
String[] parts = entry.split(" ");
LocalDate entryDate = LocalDate.parse(parts[DATE_INDEX], DATE_FORMATTER);
if (isWithinDateRange(name, entryDate, fromDate, toDate, parts)) {
int hours = Integer.parseInt(parts[HOUR_INDEX]);
int rate = Integer.parseInt(parts[RATE_INDEX]);
earned += hours * rate;
Comment on lines +34 to +36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int hours = Integer.parseInt(parts[HOUR_INDEX]);
int rate = Integer.parseInt(parts[RATE_INDEX]);
earned += hours * rate;
earned += Integer.parseInt(parts[HOUR_INDEX]) * Integer.parseInt(parts[RATE_INDEX]);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must remove 34,35,36 lines?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do just one like this arned += Integer.parseInt(parts[HOUR_INDEX]) * Integer.parseInt(parts[RATE_INDEX]); ?

}
}
return earned;
}

private boolean isWithinDateRange(String name, LocalDate entryDate, LocalDate fromDate,
LocalDate toDate, String[] parts) {
return name.equals(parts[NAME_INDEX])
&& !entryDate.isBefore(fromDate)
&& !entryDate.isAfter(toDate);
}
}
Loading