create an implementation for the method "getSalaryInfo" #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuzan
suggested changes
Jun 11, 2024
Comment on lines
14
to
17
| String recordDate = record[0]; | ||
| String recordName = record[1]; | ||
| int totalHours = Integer.parseInt(record[2]); | ||
| int salaryPerHour = Integer.parseInt(record[3]); |
| import java.time.format.DateTimeParseException; | ||
|
|
||
| public class SalaryInfo extends DataComparison { | ||
|
|
There was a problem hiding this comment.
don't leave an empty line after method/class definition
| return null; | ||
| import java.time.format.DateTimeParseException; | ||
|
|
||
| public class SalaryInfo extends DataComparison { |
There was a problem hiding this comment.
why do you extend datacomparison? it looks like just a utility class, make its method static and use directly
Comment on lines
17
to
18
| return ((dateToCheck.isEqual(startDate) || dateToCheck.isAfter(startDate)) | ||
| && (dateToCheck.isEqual(endDate) || dateToCheck.isBefore(endDate))); |
There was a problem hiding this comment.
you can shorten it to just two parts instead of 4 (using !)
| return false; | ||
| } | ||
| } | ||
|
|
|
|
||
| try { | ||
| for (String date : dates) { | ||
| String[] record = date.split("\\s+"); |
Comment on lines
32
to
36
| for (int i = 0; i < names.length; i++) { | ||
| builder.append(names[i]).append(" - ").append(employeeSalary[i]) | ||
| .append(System.lineSeparator()); | ||
| } | ||
| return builder.toString().trim(); |
There was a problem hiding this comment.
that's a third loop - two are enough (common mistakes checklist)
… it`s method to the SalaryInfo class and made it static, made 2 loops instead of 3 ones, and made date checking shorter
Elena-Bruyako
suggested changes
Jun 12, 2024
| private static final int HOURS_RATE_FROM_LIST = 3; | ||
| private static final String LINE_SEPARATOR = "\\s+"; | ||
|
|
||
| public static boolean isDateInRange(String fromDate, String toDate, String dateFromAList) { |
There was a problem hiding this comment.
Looks like this method should be private and placed after public methods
Elena-Bruyako
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.