first solution #1297
first solution #1297
Conversation
| return null; | ||
| StringBuilder getSalaryOutput = new StringBuilder(); | ||
| int[] salary = new int[names.length]; | ||
| final DateTimeFormatter formatter = DateTimeFormatter.ofPattern("dd.MM.yyyy"); |
There was a problem hiding this comment.
Since the formatter is used multiple times in the code, it should be made into a constant field. Define it as a private static final field at the class level and use an uppercase name to follow Java naming conventions for constants.
| public class SalaryInfo { | ||
|
|
||
| public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) { |
There was a problem hiding this comment.
The class and method implementation should not start with an empty line. Please remove the empty line at the beginning of the method implementation.
| public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) { | ||
| return null; | ||
| StringBuilder getSalaryOutput = new StringBuilder(); |
There was a problem hiding this comment.
The variable name 'getSalaryOutput' is not very informative. Consider renaming it to something like 'salaryReportBuilder' to better reflect its purpose.
| .append(dateFrom) | ||
| .append(" - ") | ||
| .append(dateTo); | ||
| for (String dataArray : data) { |
There was a problem hiding this comment.
Using 'dataArray' as a variable name is not informative. Consider renaming it to something like 'record' or 'dataEntry' to better reflect the data it represents.
| if (localDate.isAfter(dateFromFormated) | ||
| && localDate.isBefore(dateToFormated) | ||
| || localDate.isEqual(dateFromFormated) | ||
| || localDate.isEqual(dateToFormated)) { |
There was a problem hiding this comment.
The condition to check if the date is within the range can be simplified by using !localDate.isBefore(dateFromFormated) && !localDate.isAfter(dateToFormated), which is more readable.
| salary[j] = salary[j] | ||
| + (Integer.parseInt(dataSplit[2]) | ||
| * Integer.parseInt(dataSplit[3])); |
There was a problem hiding this comment.
Instead of recalculating the salary each time, consider using a local variable to store the parsed values of 'dataSplit[2]' and 'dataSplit[3]' before the multiplication to improve code readability.
| } | ||
| } | ||
| } | ||
| for (int i = 0; i < salary.length; i++) { |
There was a problem hiding this comment.
There are redundant loops here, the task can be solved with a maximum of two loops. Consider combining the logic to reduce the number of loops and increase efficiency.
| @@ -5,40 +5,35 @@ | |||
|
|
|||
| public class SalaryInfo { | |||
|
|
|||
| private static final DateTimeFormatter formatter = DateTimeFormatter.ofPattern("dd.MM.yyyy"); | |||
There was a problem hiding this comment.
Constant variables should be all uppercase letters.
You can have a look here: https://mate-academy.github.io/style-guides/java/java.html#s5.2.4-constant-names
| for (String dataEntry : data) { | ||
| String[] dataSplit = dataEntry.split(" "); | ||
| LocalDate localDate = LocalDate.parse(dataSplit[0], formatter); | ||
| if (!localDate.isBefore(dateFromFormated) && !localDate.isAfter(dateToFormated)) { |
There was a problem hiding this comment.
I would extract the check in the if to a separate method for more readability and clarity, eg. isDataWithinRange()
| LocalDate dateFromFormated = LocalDate.parse(dateFrom, formatter); | ||
| LocalDate dateToFormated = LocalDate.parse(dateTo, formatter); |
There was a problem hiding this comment.
You should keep these variables. Now when you are calling your new method (isDataWithinRange) you are unnecessary creating 2 new variables on each method call. Rework your new method a bit, so that it accepts as parameters already formated dateFrom and dateTo.
No description provided.