Solution #1308
Solution #1308
Conversation
|
|
||
| public Employee(String name) { | ||
| this.name = name; | ||
| this.balance = 0; |
There was a problem hiding this comment.
0 - int is initialized to 0 by default
|
|
||
| public class DateService { | ||
| public static boolean dateInRange(String date, String fromDate, String toDate) { | ||
| DateTimeFormatter formatter = DateTimeFormatter.ofPattern("dd.MM.yyyy"); |
There was a problem hiding this comment.
Let's make this variable a constant
| import java.time.LocalDate; | ||
| import java.time.format.DateTimeFormatter; | ||
|
|
||
| public class DateService { |
| return !dateFormatted.isBefore(fromDateFormatted) | ||
| && !dateFormatted.isAfter(toDateFormatted); |
There was a problem hiding this comment.
logical NOT operator is difficult to read, so avoid using them if possible
| public int getBalance() { | ||
| return balance; | ||
| } | ||
|
|
| package core.basesyntax; | ||
|
|
||
| public class EmployeeService { | ||
| public static Employee getEmployeeByName(Employee[] employees, String name) { |
There was a problem hiding this comment.
Don't use static methods in your solution
Static methods are in general a bad practice. Let's better create an instance of a class which method you want to call.
| for (int i = 0; i < names.length; i++) { | ||
| employees[i] = new Employee(names[i]); | ||
| } |
There was a problem hiding this comment.
Don’t create redundant loops. Two is enough.
The more loops you have, the slower your code may get, so try to solve task with minimum amount.
Now I see 4 loops in the solution, think about how to refactor it, and improve the performance of the solution.
| } | ||
|
|
||
| for (String dataRow: data) { | ||
| String[] dataRowArray = dataRow.split(" "); |
There was a problem hiding this comment.
Any magic numbers and symbols should be constants. Check all your solution.
| @@ -2,6 +2,33 @@ | |||
|
|
|||
| public class SalaryInfo { | |||
| public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) { | |||
| return null; | |||
| Employee[] employees = new Employee[names.length]; | |||
There was a problem hiding this comment.
This method is too big, can you encapsulate the logic in private methods?
No description provided.