Implemented method getSalaryInfo #1333
Conversation
There was a problem hiding this comment.
Great work on your getSalaryInfo method implementation! 👍 It's impressive to see that you've followed most of the checklist requirements, including the use of LocalDate and DateTimeFormatter, as well as StringBuilder for string concatenation. Just remember for the future to use System.lineSeparator() for cross-platform compatibility and consider more descriptive variable names. Keep up the good work, and always strive to make your code as clear and maintainable as possible! 😊👨💻
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| private static final int HOURS_INDEX = 2; | ||
| private static final int PER_HOUR_INDEX = 3; | ||
|
|
||
| public static String getSalaryInfo(String[] names, String[] data, |
There was a problem hiding this comment.
Remember to avoid beginning a method implementation with an empty line. In Java, it's a common practice to start the method body immediately after the method signature without an empty line to keep the code compact and readable.
| LocalDate fromDate = LocalDate.parse(dateFrom, DATE_FORMATTER); | ||
| LocalDate toDate = LocalDate.parse(dateTo, DATE_FORMATTER); | ||
| StringBuilder stringBuilder = new StringBuilder(); | ||
| stringBuilder.append("Report for period ").append(dateFrom) |
There was a problem hiding this comment.
To ensure consistency across different operating systems, use System.lineSeparator() instead of hardcoded spaces when concatenating strings that are meant to be on separate lines.
| for (String name : names) { | ||
| int salary = 0; | ||
| for (String info : data) { | ||
| String[] parts = info.split(" "); |
There was a problem hiding this comment.
Consider using more informative variable names. The name 'parts' is quite generic and does not convey the meaning of the data it holds. A name like 'recordParts' or 'workRecord' might be more descriptive.
| salary += payPerHour * workedHours; | ||
| } | ||
| } | ||
| stringBuilder.append(System.lineSeparator()).append(name).append(" - ").append(salary); |
There was a problem hiding this comment.
Use System.lineSeparator() for consistency across different operating systems instead of relying on the default behavior of StringBuilder.append() which might not always use the correct line separator.
| if (employeeName.equals(name) | ||
| && (workingDays.isAfter(fromDate) || workingDays.isEqual(fromDate)) | ||
| && (workingDays.isBefore(toDate) || workingDays.isEqual(toDate))) { |
There was a problem hiding this comment.
think how you can shorten this to just two checks instead of for (use ! isBefore, ! isAfter)
No description provided.