Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented method getSalaryInfo(...) according to requirements #1334

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

implemented method getSalaryInfo(...) according to requirements #1334

wants to merge 4 commits into from

Commits on Sep 23, 2024

  1. implemented method getSalaryInfo(...) according to requirements of RE… 

    …ADME.MD
    @opdhk
    opdhk committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8ea1383 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. fixed issues: 

    * parsing dateFrom and dateTo transferred outside the loop;
* hardcoded delimiter ' - ' changed to constant;
* employee name with delimiters used to prevent situation for incorrect index search if employee name is a substring for another employee name
* recommendation to change stringBuilder.toString() instead of String.valueOf(stringBuilder) ignored
    @opdhk
    opdhk committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    56e7267 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. changed according to the reviewer's fixes

    @opdhk
    opdhk committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6e8dfe4 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. 2nd iteration of changes according to the reviewer's fixes

    @opdhk
    opdhk committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9e53943 View commit details
    Browse the repository at this point in the history