Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solved task #1342

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

solved task #1342

wants to merge 5 commits into from

Conversation

gubber230
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your Pull Request! 🌟 It looks like you've tackled the core functionality well. Just a couple of tips for the future: consider using System.lineSeparator() for compatibility across operating systems, and try to avoid starting your classes or methods with an empty line for better code readability. Keep up the good work! 👍

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/main/java/core/basesyntax/SalaryInfo.java Show resolved Hide resolved
src/main/java/core/basesyntax/SalaryInfo.java Outdated Show resolved Hide resolved
src/main/java/core/basesyntax/SalaryInfo.java Outdated Show resolved Hide resolved
src/main/java/core/basesyntax/SalaryInfo.java Outdated Show resolved Hide resolved
src/main/java/core/basesyntax/SalaryInfo.java Outdated Show resolved Hide resolved
src/main/java/core/basesyntax/SalaryInfo.java Outdated Show resolved Hide resolved
src/main/java/core/basesyntax/SalaryInfo.java Outdated Show resolved Hide resolved
src/main/java/core/basesyntax/SalaryInfo.java Outdated Show resolved Hide resolved
public class SalaryInfo {
private static final DateTimeFormatter f = DateTimeFormatter.ofPattern("dd.MM.yyyy");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename f

Copy link

@Elena-Bruyako Elena-Bruyako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build failed, fix it first

Copy link

@liliia-ponomarenko liliia-ponomarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants