all conditions are met #1344
all conditions are met #1344
Conversation
There was a problem hiding this comment.
Great job on addressing the task! 🌟 The issues mentioned are minor and do not significantly impact the functionality or security of your code. Remember to keep an eye out for redundant empty lines and consider defining formatters as constants for better practice. Using a HashMap is not recommended for this task, but since this isn't a critical issue, I'm approving your PR. Keep up the good work, and always strive to refine your code! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| public class SalaryInfo { | ||
|
|
||
| public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) { |
There was a problem hiding this comment.
The class or method implementation should not begin with an empty line. Please remove the redundant empty line at the start of the getSalaryInfo method.
| public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) { | ||
| return null; | ||
| // Формат дат | ||
| DateTimeFormatter formatter = DateTimeFormatter.ofPattern("dd.MM.yyyy"); |
There was a problem hiding this comment.
According to the checklist, if you create a formatter, it should be made a constant field. This will improve code readability and maintainability.
| @@ -1,7 +1,53 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| import java.time.LocalDate; | |||
| import java.time.format.DateTimeFormatter; | |||
| import java.util.HashMap; | |||
There was a problem hiding this comment.
The checklist specifies not to use HashMaps or any other Map data structure for this task. Try to solve the problem without using these data structures.
No description provided.