implemented method getSalaryInfo #1347
Conversation
There was a problem hiding this comment.
Great job on the Pull Request! Just a couple of minor suggestions: consider optimizing the way you handle line breaks with StringBuilder and use System.lineSeparator() for better cross-platform support. These changes aren't critical, but they'll make your code more robust and maintainable. Keep up the good work! 😊👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| message.append("Report for period ") | ||
| .append(dateFrom).append(" - ") | ||
| .append(dateTo).append("\r\n"); |
There was a problem hiding this comment.
Instead of using '\r\n' for line breaks, use 'System.lineSeparator()' for better compatibility across different operating systems.
| totalSalary += hoursWorked * salaryPerHour; | ||
| } | ||
| } | ||
| message.append(name).append(" - ").append(totalSalary).append("\r\n"); |
There was a problem hiding this comment.
Use 'System.lineSeparator()' instead of '\r\n' when appending the salary information to ensure the line separator is handled correctly across various operating systems.
| message.deleteCharAt(message.length() - 1); | ||
| message.deleteCharAt(message.length() - 1); |
There was a problem hiding this comment.
Instead of manually deleting the last characters to remove the extra line break, consider using 'StringBuilder' methods more effectively. For example, you could avoid appending the extra line separator after the last record, or use 'StringBuilder.setLength' to trim the 'StringBuilder' to the correct length.
| StringBuilder message = new StringBuilder(); | ||
|
|
||
| message.append("Report for period ") | ||
| .append(dateFrom).append(" - ") |
There was a problem hiding this comment.
hyphen also should make constant
| if (employeeName.equals(name) | ||
| && (workDate.isEqual(startDate) || workDate.isEqual(endDate) | ||
| || (workDate.isAfter(startDate) && workDate.isBefore(endDate)))) { |
There was a problem hiding this comment.
you can move this conditional to private method and make your method more readable;)
| } | ||
| message.append(name).append(" - ").append(totalSalary).append(System.lineSeparator()); | ||
| } | ||
| message.setLength(message.length() - System.lineSeparator().length()); |
There was a problem hiding this comment.
to remove line separator after outputing last element
No description provided.