fixed method' #1353
fixed method' #1353
Conversation
There was a problem hiding this comment.
Great job on the implementation! While using StringBuilder can enhance performance in certain scenarios, your current approach is perfectly fine here. Keep up the good work and continue exploring ways to optimize your code! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| StringBuilder salaryInfo = new StringBuilder("Report for period " | ||
| + dateFrom + " - " + dateTo); |
There was a problem hiding this comment.
Consider using StringBuilder for concatenating strings within the loop to improve performance. However, in this case, since it's outside of the loop, it's acceptable to use simple concatenation.
| private static final DateTimeFormatter DATE_FORMATTER = | ||
| DateTimeFormatter.ofPattern("dd.MM.yyyy"); | ||
| private static final int DAY_POSITION = 0; | ||
| private static final int NAME = 1; |
There was a problem hiding this comment.
| private static final int NAME = 1; | |
| private static final int NAME_INDEX = 1; |
| DateTimeFormatter.ofPattern("dd.MM.yyyy"); | ||
| private static final int DAY_POSITION = 0; | ||
| private static final int NAME = 1; | ||
| private static final int HOUR = 2; |
There was a problem hiding this comment.
| private static final int HOUR = 2; | |
| private static final int HOUR_INDEX = 2; |
| for (String name : names) { | ||
| int salary = 0; | ||
| for (String info: data) { | ||
| String[] infoSplit = info.split(" "); |
There was a problem hiding this comment.
| String[] infoSplit = info.split(" "); | |
| String[] infoSplit = info.split(SPACE); |
| salary += hours * salaryHour; | ||
| } | ||
| } | ||
| salaryInfo.append(System.lineSeparator()).append(name).append(" - ").append(salary); |
There was a problem hiding this comment.
| salaryInfo.append(System.lineSeparator()).append(name).append(" - ").append(salary); | |
| salaryInfo.append(System.lineSeparator()).append(name).append(DASH).append(salary); |
| private static final int NAME = 1; | ||
| private static final int HOUR = 2; | ||
| private static final int SALARY_PER_HOUR = 3; | ||
|
|
||
| public String getSalaryInfo(String[] names, String[] data, String dateFrom, String dateTo) { |
There was a problem hiding this comment.
This method is very complicated, please break it down into several methods, for example: createReport, calculateSallaryInfo
No description provided.